Skip to content

[enterprise-4.14] OCPBUGS#32782: Doc improvements related to scaling storage of clusters #75066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2024
Merged

[enterprise-4.14] OCPBUGS#32782: Doc improvements related to scaling storage of clusters #75066

merged 1 commit into from
May 8, 2024

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Apr 24, 2024 •
edited
Loading

Version(s):
4.14

Issue:
OCPBUGS-32782

Link to docs preview:
Preview

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 24, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 24, 2024 •
edited
Loading

🤖 Wed May 08 12:06:40 - Prow CI generated the docs preview:

https://75066--ocpdocs-pr.netlify.app/
https://75066--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html

@sr1kar99 sr1kar99 force-pushed the 32782-scaling-storage-doc-improv branch 2 times, most recently from d14407a to 8b9b933 Compare April 24, 2024 06:39
@sr1kar99
Copy link
Contributor Author

@jakobmoellerdev @suleymanakbas91
Could you please review this PR?
Thanks!

@sr1kar99 sr1kar99 changed the title OCPBUGS#32782: Doc improvements related to scaling storage of clusters [enterprise-4.14] OCPBUGS#32782: Doc improvements related to scaling storage of clusters Apr 29, 2024
jakobmoellerdev
jakobmoellerdev reviewed Apr 29, 2024
View reviewed changes
@sr1kar99 sr1kar99 force-pushed the 32782-scaling-storage-doc-improv branch 2 times, most recently from d550d9b to 0cfd2b6 Compare May 6, 2024 08:54
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 6, 2024

@radeore
Can you please review this PR?
Thanks!

@radeore
Copy link

radeore commented May 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@sr1kar99 sr1kar99 force-pushed the 32782-scaling-storage-doc-improv branch from 0cfd2b6 to d69bc60 Compare May 7, 2024 04:21
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 7, 2024

New changes are detected. LGTM label has been removed.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 7, 2024

@jakobmoellerdev
Updated the content as per the suggestions.
Could you PTAL?
Thanks!

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 7, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 7, 2024
@adellape adellape self-assigned this May 7, 2024
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 7, 2024
adellape
adellape reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 8, 2024
@adellape adellape added this to the Continuous Release milestone May 8, 2024
@adellape
Copy link
Contributor

adellape commented May 8, 2024

@sr1kar99 It looks like this PR is more or less the 4.14 version of the earlier #71942, which merged previously to main, 4.15, and 4.16; can you confirm? Just want to make it clear during merge review, so that there's no questions about why this is targeting the enterprise-4.14 branch only. Thanks!

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 8, 2024 •
edited
Loading

@sr1kar99 It looks like this PR is more or less the 4.14 version of the earlier #71942, which merged previously to main, 4.15, and 4.16; can you confirm? Just want to make it clear during merge review, so that there's no questions about why this is targeting the enterprise-4.14 branch only. Thanks!

Hi @adellape
Yes! You are right. Similar PR for 4.15+ has been merged already. The reason for having a separate PR for 4.14 is that 4.14 and lower versions support this Operator only on single-node OpenShift.

Thanks for adding the 4.15+ PR link. :)

@sr1kar99 sr1kar99 force-pushed the 32782-scaling-storage-doc-improv branch from d69bc60 to c15a14b Compare May 8, 2024 11:13
@sr1kar99 sr1kar99 force-pushed the 32782-scaling-storage-doc-improv branch from c15a14b to 324311e Compare May 8, 2024 11:59
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 8, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 8, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 8, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 8, 2024
@adellape adellape merged commit 6307f12 into openshift:enterprise-4.14 May 8, 2024
@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 8, 2024
@adellape adellape mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@adellape adellape adellape left review comments

@DanielFroehlich DanielFroehlich DanielFroehlich left review comments

@jakobmoellerdev jakobmoellerdev jakobmoellerdev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adellape adellape

@radeore radeore

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@sr1kar99 @ocpdocs-previewbot @radeore @adellape @DanielFroehlich @jakobmoellerdev