Skip to content

Conversation

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2024

@rohennes: This pull request references TELCODOCS-1779 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

TELCODOCS-1779:

Version(s):
KB article only.

Issue:
https://issues.redhat.com/browse/TELCODOCS-1779

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2024

@rohennes: This pull request references TELCODOCS-1779 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

TELCODOCS-1779:

Version(s):
KB article only.

Issue:
https://issues.redhat.com/browse/TELCODOCS-1779

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2024
@rohennes rohennes force-pushed the TELCODOCS-1779 branch 7 times, most recently from 0f61486 to 2de6bb8 Compare April 30, 2024 10:46
@rohennes rohennes force-pushed the TELCODOCS-1779 branch 2 times, most recently from a7312d1 to a11e972 Compare April 30, 2024 15:44
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2024

@rohennes: This pull request references TELCODOCS-1779 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

TELCODOCS-1779:

Version(s):
KB article only.

Issue:
https://issues.redhat.com/browse/TELCODOCS-1779

Link to docs preview:
https://75088--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/ibi-image-based-install.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes rohennes force-pushed the TELCODOCS-1779 branch 3 times, most recently from 500bd30 to 8038a61 Compare May 1, 2024 15:25
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 1, 2024

@rohennes: This pull request references TELCODOCS-1779 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

TELCODOCS-1779:

Version(s):
KB article only.

Issue:
https://issues.redhat.com/browse/TELCODOCS-1779

Link to docs preview:
https://75088--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image-base-install/ibi-edge-image-based-install.html
https://75088--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image-base-install/ibi-factory-image-based-install.html
https://75088--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image-base-install/ibi-understanding-image-based-install.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes rohennes force-pushed the TELCODOCS-1779 branch 3 times, most recently from ea41b9b to a35e286 Compare May 2, 2024 11:22
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2024

@rohennes: This pull request references TELCODOCS-1779 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

TELCODOCS-1779:

Version(s):
KB article only.

Issue:
https://issues.redhat.com/browse/TELCODOCS-1779

Link to docs preview:
Intro:
https://75088--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image-base-install/ibi-understanding-image-based-install.html
Factory install:
https://75088--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image-base-install/ibi-factory-image-based-install.html
Edge deployment:
https://75088--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image-base-install/ibi-edge-image-based-install.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes rohennes force-pushed the TELCODOCS-1779 branch 6 times, most recently from dd55f11 to f01a11a Compare June 19, 2024 10:59
@rohennes
Copy link
Contributor Author

/retest

@rohennes rohennes force-pushed the TELCODOCS-1779 branch 4 times, most recently from 061e5ca to d2a531a Compare June 21, 2024 09:53
@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1779 branch 3 times, most recently from bd5b262 to c87c0ba Compare June 25, 2024 09:05
- destination: 0.0.0.0/0
next-hop-address: <hop_address>
next-hop-interface: enp1s0
table-id: <table_id>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eranco74 is it required? Or maybe is isn't it always 254? as default at least

@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1779 branch 5 times, most recently from 611bed8 to 05ff05e Compare June 25, 2024 14:23
|`extraPartitionLabel`|`string`|The label of the extra partition you use for `/var/lib/containers`. The default label is `varlibcontainers`.
|`extraPartitionNumber`|`unsigned integer`|The number of the extra partition you use for `/var/lib/containers`. The default number is `5`.
|`skipDiskCleanup`|`boolean`|The installation process formats the disk on the host. Set this specification to 'true' to skip this step. The default is `false`.
|`rhcosLiveIso`|`string`|Specifies the URL for the {op-system} live ISO image used for generating the installation ISO. The default value is `https://mirror.openshift.com/pub/openshift-v4/amd64/dependencies/rhcos/latest/rhcos-live.x86_64.iso`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently a required field:

$ sudo ./bin/ib-cli create-iso -d ibi-iso-workdir
ib-cli assists Image Based Install (IBI).

  Find more information at: https://github.com/openshift-kni/lifecycle-agent/blob/main/ib-cli/README.md
	
INFO[2024-06-26 15:46:33] Installation ISO creation has started        
FATA[2024-06-26 15:46:33] Error reading configuration file: config file validation failed: rhcosLiveIso is required 

Add nmstateconfig example

Add note about NIC name must match actual name in OS
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2024

@rohennes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 3a9b0f5 link true /test validate-asciidoc
ci/prow/validate-portal 3a9b0f5 link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eranco74
Copy link

@rohennes we can close this, right?

@rohennes
Copy link
Contributor Author

rohennes commented Sep 23, 2024

@rohennes we can close this, right?

Yes, closing now.

@rohennes rohennes closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.