Skip to content

Conversation

mramendi
Copy link
Contributor

@mramendi mramendi commented May 4, 2024

Version(s):

pipeline-docs-main only

Issue:

RHDEVDOCS 5984

Link to docs preview:

https://75534--ocpdocs-pr.netlify.app/openshift-pipelines/latest/install_config/customizing-configurations-in-the-tektonconfig-cr.html#op-disabling-inline-spec_customizing-configurations-in-the-tektonconfig-cr

QE review:

  • QE has approved this change.

Additional information:

NOTE TO PEER/MERGE REVIEWERS: the added module uses a concept format and not a procedure format in order to preserve uniformity with other modules in the assembly. Adding a full procedure to edit the TektonConfig CR to every module would be repetitive and would also make for a very large PR. See the preview. or else https://docs.openshift.com/pipelines/1.14/install_config/customizing-configurations-in-the-tektonconfig-cr.html#op-changing-default-service-account_customizing-configurations-in-the-tektonconfig-cr in the current documentation, for several modules that immediately precede this module

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 4, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 4, 2024

@mramendi
Copy link
Contributor Author

mramendi commented May 4, 2024

Copy link

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

|You cannot use a `taskSpec:` spec to define a task inside a `Pipeline` CR. Instead, you must use a `taskRef:` spec to incorporate a task from a `Task` CR or to specify a task using a resolver.

|`pipelinerun`
|You cannot use a `pipelineSpec:` spec to define a pipeline inside a `PipelineRun` CR. Instead, you must use a `pipelineRef:` spec to incorporate a pipeline from a `Pipeline` CR or to specify a pipeline using a resolver.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm what happens when I set disable-inline-spec: "pipeline" ... will I be able to use taskSpec inside pipelinerun?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Setting pipeline only disables setting taskSpec and pipelineSpec in the Pipeline resource.

@mramendi
Copy link
Contributor Author

mramendi commented May 8, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 8, 2024
@adellape adellape self-assigned this May 8, 2024
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 8, 2024
@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR pipelines and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 8, 2024
@adellape adellape added this to the Continuous Release milestone May 8, 2024
@mramendi
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented May 10, 2024

@mramendi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mramendi
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 10, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 10, 2024
@adellape adellape merged commit 46398d7 into openshift:pipelines-docs-main May 10, 2024
@adellape
Copy link
Contributor

adellape commented May 10, 2024

@mramendi I see it looks we got QE review here in comments and the issue was VERIFIED, but just a reminder to check the "QE has approved this change" box in PR description to save some merge-review time. 🙇

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR pipelines size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants