-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS 5984 disabling inline spec #75534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS 5984 disabling inline spec #75534
Conversation
🤖 Fri May 10 18:54:47 - Prow CI generated the docs preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|You cannot use a `taskSpec:` spec to define a task inside a `Pipeline` CR. Instead, you must use a `taskRef:` spec to incorporate a task from a `Task` CR or to specify a task using a resolver. | ||
|
||
|`pipelinerun` | ||
|You cannot use a `pipelineSpec:` spec to define a pipeline inside a `PipelineRun` CR. Instead, you must use a `pipelineRef:` spec to incorporate a pipeline from a `Pipeline` CR or to specify a pipeline using a resolver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khrm what happens when I set disable-inline-spec: "pipeline"
... will I be able to use taskSpec
inside pipelinerun
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Setting pipeline
only disables setting taskSpec
and pipelineSpec
in the Pipeline resource.
/label peer-review-needed |
/retest |
@mramendi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
@mramendi I see it looks we got QE review here in comments and the issue was VERIFIED, but just a reminder to check the "QE has approved this change" box in PR description to save some merge-review time. 🙇 |
Version(s):
pipeline-docs-main only
Issue:
RHDEVDOCS 5984
Link to docs preview:
https://75534--ocpdocs-pr.netlify.app/openshift-pipelines/latest/install_config/customizing-configurations-in-the-tektonconfig-cr.html#op-disabling-inline-spec_customizing-configurations-in-the-tektonconfig-cr
QE review:
Additional information:
NOTE TO PEER/MERGE REVIEWERS: the added module uses a concept format and not a procedure format in order to preserve uniformity with other modules in the assembly. Adding a full procedure to edit the TektonConfig CR to every module would be repetitive and would also make for a very large PR. See the preview. or else https://docs.openshift.com/pipelines/1.14/install_config/customizing-configurations-in-the-tektonconfig-cr.html#op-changing-default-service-account_customizing-configurations-in-the-tektonconfig-cr in the current documentation, for several modules that immediately precede this module