Skip to content

OSDOCS-10443: Tech preview RN for oc adm upgrade status #75679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

OSDOCS-10443: Tech preview RN for oc adm upgrade status #75679

merged 1 commit into from
May 16, 2024

Conversation

@obrown1205
Copy link
Contributor

@obrown1205 obrown1205 commented May 8, 2024 •
edited
Loading

Version(s):
4.16

Issue:
OSDOCS-10443

Link to docs preview:
https://75679--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html#ocp-4-16-oc-adm-upgrade-status-tp

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2024 •
edited by openshift-ci bot
Loading

@obrown1205: This pull request references OSDOCS-10443 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 8, 2024 •
edited
Loading

🤖 Thu May 16 17:19:09 - Prow CI generated the docs preview:

https://75679--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2024 •
edited by openshift-ci bot
Loading

@obrown1205: This pull request references OSDOCS-10443 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-10443

Link to docs preview:
https://75679--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html#ocp-4-16-oc-adm-upgrade-status-tp

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2024 •
edited by openshift-ci bot
Loading

@obrown1205: This pull request references OSDOCS-10443 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-10443

Link to docs preview:
https://75679--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html#ocp-4-16-oc-adm-upgrade-status-tp

QE review:
N/A

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@obrown1205
Copy link
Contributor Author

obrown1205 commented May 8, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 8, 2024
@obrown1205 obrown1205 force-pushed the OSDOCS-10443-rn branch 2 times, most recently from 31e74a1 to 742b0f4 Compare May 8, 2024 19:21
@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels May 8, 2024
skopacz1
skopacz1 reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and a few suggestions, otherwise LGTM!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 8, 2024
@petr-muller
Copy link
Member

petr-muller commented May 9, 2024

/cc

@openshift-ci openshift-ci bot requested a review from petr-muller May 9, 2024 11:38
@obrown1205 obrown1205 force-pushed the OSDOCS-10443-rn branch 2 times, most recently from 217a4a4 to 15fc7a8 Compare May 9, 2024 14:44
@obrown1205
Copy link
Contributor Author

obrown1205 commented May 9, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 9, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 9, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented May 9, 2024

I think release notes still need to be QE reviewed

@obrown1205
Copy link
Contributor Author

obrown1205 commented May 9, 2024

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot
Loading

@obrown1205: This pull request references OSDOCS-10443 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-10443

Link to docs preview:
https://75679--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html#ocp-4-16-oc-adm-upgrade-status-tp

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skopacz1 skopacz1 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 9, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2024 •
edited by openshift-ci bot
Loading

@obrown1205: This pull request references OSDOCS-10443 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-10443

Link to docs preview:
https://75679--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html#ocp-4-16-oc-adm-upgrade-status-tp

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@obrown1205
Copy link
Contributor Author

obrown1205 commented May 15, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 15, 2024
ShaunaDiaz
ShaunaDiaz reviewed May 15, 2024
View reviewed changes
release_notes/ocp-4-16-release-notes.adoc Outdated
[id="ocp-4-16-oc-adm-upgrade-status-tp"]
==== Introducing the `oc adm upgrade status` command (Technology Preview)

Previously, users could run the `oc adm upgrade` command to retrieve limited information about the cluster update status. With this release, there is now a technology preview `oc adm upgrade status` command in addition to `oc adm upgrade`, which decouples the status information from `oc adm upgrade` and complements the UI by providing customers with specific information regarding their cluster update, including the status of the control plane and worker node updates.
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Previously, users could run the `oc adm upgrade` command to retrieve limited information about the cluster update status. With this release, there is now a technology preview `oc adm upgrade status` command in addition to `oc adm upgrade`, which decouples the status information from `oc adm upgrade` and complements the UI by providing customers with specific information regarding their cluster update, including the status of the control plane and worker node updates.
Previously, users could run the `oc adm upgrade` command to retrieve limited information about the cluster update status. With this release, a technology preview `oc adm upgrade status` command is available in addition to `oc adm upgrade`. The new command removes the status information from `oc adm upgrade`. Specific information regarding your cluster update can now be obtained with the `oc adm upgrade status` command and includes the status of control plane and worker node updates.

"complementing the UI ..." this phrase seems meaningless to me; what does it mean? it's the same info as available in the console, er?

@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented May 15, 2024

@obrown1205 I know this is a merge review, but this release note still doesn't look right. We don't usually talk to our customers in third person, etc. Please consider changes and put back in queue? TY!

@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented May 15, 2024

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 15, 2024
@obrown1205
Copy link
Contributor Author

obrown1205 commented May 15, 2024

@obrown1205 I know this is a merge review, but this release note still doesn't look right. We don't usually talk to our customers in third person, etc. Please consider changes and put back in queue? TY!

Can do! Thank you!

@obrown1205 obrown1205 force-pushed the OSDOCS-10443-rn branch 2 times, most recently from 322ee7d to 7dd65c6 Compare May 15, 2024 18:43
@obrown1205
Copy link
Contributor Author

obrown1205 commented May 15, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 15, 2024
@maxwelldb maxwelldb added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 16, 2024
@maxwelldb maxwelldb self-requested a review May 16, 2024 12:43
@maxwelldb maxwelldb added this to the Planned for 4.16 GA milestone May 16, 2024
maxwelldb
maxwelldb reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion added. Re-label when ready.

@maxwelldb maxwelldb removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 16, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2024

@obrown1205: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@obrown1205
Copy link
Contributor Author

obrown1205 commented May 16, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 16, 2024
@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented May 16, 2024

/remove-label merge-review-needed

@ShaunaDiaz ShaunaDiaz merged commit f860234 into openshift:enterprise-4.16 May 16, 2024
@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxwelldb maxwelldb maxwelldb left review comments

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

@skopacz1 skopacz1 skopacz1 left review comments

+3 more reviewers

@wking wking wking approved these changes

@JianLi-RH JianLi-RH JianLi-RH left review comments

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JianLi-RH JianLi-RH

@evakhoni evakhoni

Labels

branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.16 GA

Development

Successfully merging this pull request may close these issues.

10 participants

@obrown1205 @openshift-ci-robot @ocpdocs-previewbot @petr-muller @skopacz1 @JianLi-RH @evakhoni @ShaunaDiaz @wking @maxwelldb