Skip to content

[enterprise-4.15] OBSDOCS-1031: Add deprecation info for prometheus-adapter to OCP 4.15… #75713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

[enterprise-4.15] OBSDOCS-1031: Add deprecation info for prometheus-adapter to OCP 4.15… #75713

merged 1 commit into from
May 23, 2024

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented May 9, 2024 •
edited
Loading

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

Edit: The change management has been completed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-1031

Link to docs preview:

Additional information: This issue requires to go through the change management process:

  • QE has approved this change.
  • Eng has approved this change.
  • PM has approved this change.
  • PX has approved this change.
  • Docs lead has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Link to docs preview:

Additional information: This issue requires to go through the change management process:

  • QE has approved this change.
  • Eng has approved this change.
  • PM has approved this change.
  • PX has approved this change.
  • Docs lead has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 9, 2024 •
edited
Loading

🤖 Mon May 13 08:01:09 - Prow CI generated the docs preview:

https://75713--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

  • QE has approved this change.
  • Eng has approved this change.
  • PM has approved this change.
  • PX has approved this change.
  • Docs lead has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

  • QE has approved this change.
  • Eng has approved this change.
  • PM has approved this change.
  • PX has approved this change.
  • DPM has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bburt-rh
bburt-rh reviewed May 9, 2024
View reviewed changes
bburt-rh
bburt-rh reviewed May 9, 2024
View reviewed changes
bburt-rh
bburt-rh reviewed May 9, 2024
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

  • QE has approved this change.
  • Eng has approved this change.
  • PM has approved this change.
  • PX has approved this change.
  • DPM has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

  • QE has approved this change.
  • Eng has approved this change.
  • PM has approved this change.
  • PX has approved this change.
  • DPM has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 10, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 10, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bburt-rh
Copy link
Contributor

lgtm (as Monitoring DPM)

simonpasquier
simonpasquier reviewed May 13, 2024
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@juzhao
Copy link

juzhao commented May 13, 2024

the only concern is if we can make metrics-server GA in 4.16, the 4.16 target branch date is May 17, 2024, but the epic is still in progress(bug on SNO cluster is not fixed), see MON-3537. cc: @slashpai

@juzhao
Copy link

juzhao commented May 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Senthamilarasu-STA
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label May 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier
Copy link

/lgtm

@jan--f
Copy link
Contributor

jan--f commented May 14, 2024

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@w1dg3r
Copy link

w1dg3r commented May 20, 2024

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 20, 2024

@w1dg3r: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 20, 2024
@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-in-progress
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 20, 2024
GroceryBoyJr
GroceryBoyJr reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 20, 2024
@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 23, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1031 which is a valid jira issue.

In response to this:

Version(s): enterprise-4.15

Issue: OBSDOCS-1031

Links to docs preview:

Additional information: This issue requires to go through the change management process:

Edit: The change management has been completed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 23, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 23, 2024
@JoeAldinger JoeAldinger merged commit 039b105 into openshift:enterprise-4.15 May 23, 2024
@JoeAldinger JoeAldinger added this to the Continuous Release milestone May 23, 2024
@eromanova97 eromanova97 deleted the OBSDOCS-1031 branch May 23, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@bburt-rh bburt-rh bburt-rh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jan--f jan--f

@simonpasquier simonpasquier

@juzhao juzhao

Labels

branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR px-approved Signifies that Product Support has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.