Skip to content

[RHACS] ROX-19674: Documenting the need for private endpoint for ECR integration #75782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

[RHACS] ROX-19674: Documenting the need for private endpoint for ECR integration #75782

merged 1 commit into from
May 23, 2024

Conversation

@agantony
Copy link
Contributor

@agantony agantony commented May 10, 2024 •
edited
Loading

Version(s):
4.3+

Issue:
https://issues.redhat.com/browse/ROX-19674

Link to docs preview:
https://75782--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-with-image-registries.html

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.5
    • rhacs-docs-4.4
    • rhacs-docs-4.3

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 10, 2024 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-19674 which is a valid jira issue.

In response to this:

Version(s):
4.3+

Issue:
https://issues.redhat.com/browse/ROX-19674

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.5
    • rhacs-docs-4.4
    • rhacs-docs-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 10, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 10, 2024 •
edited
Loading

🤖 Thu May 23 15:25:14 - Prow CI generated the docs preview:

https://75782--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-with-image-registries.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 10, 2024 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-19674 which is a valid jira issue.

In response to this:

Version(s):
4.3+

Issue:
https://issues.redhat.com/browse/ROX-19674

Link to docs preview:
https://75782--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-with-image-registries.html

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.5
    • rhacs-docs-4.4
    • rhacs-docs-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony
Copy link
Contributor Author

agantony commented May 10, 2024

/label RHACS

@openshift-ci openshift-ci bot added the RHACS Label for RHACS related PRs that go in the rhacs-docs branch label May 10, 2024
@srcporter
Copy link

srcporter commented May 17, 2024

lgtm!

srcporter
srcporter approved these changes May 17, 2024
View reviewed changes
Copy link

@srcporter srcporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 21, 2024 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-19674 which is a valid jira issue.

In response to this:

Version(s):
4.3+

Issue:
https://issues.redhat.com/browse/ROX-19674

Link to docs preview:
https://75782--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-with-image-registries.html

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.5
    • rhacs-docs-4.4
    • rhacs-docs-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony force-pushed the ROX19674-rhacs-docs-main branch from afdfd1f to eb9580e Compare May 21, 2024 15:31
@kcarmichael08 kcarmichael08 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 23, 2024
kcarmichael08
kcarmichael08 reviewed May 23, 2024
View reviewed changes
kcarmichael08
kcarmichael08 reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion; otherwise lgtm!

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented May 23, 2024

Needs a rebase also before merging.

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 23, 2024
@agantony agantony force-pushed the ROX19674-rhacs-docs-main branch from eb9580e to 714d8fe Compare May 23, 2024 15:16
@agantony agantony force-pushed the ROX19674-rhacs-docs-main branch from 714d8fe to d5dd34e Compare May 23, 2024 15:19
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2024

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 23, 2024
@kcarmichael08 kcarmichael08 merged commit 5a84ad4 into openshift:rhacs-docs-main May 23, 2024
@kcarmichael08
Copy link
Contributor

kcarmichael08 commented May 23, 2024

/cherrypick rhacs-docs-4.3

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented May 23, 2024

/cherrypick rhacs-docs-4.4

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented May 23, 2024

/cherrypick rhacs-docs-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 23, 2024

@kcarmichael08: new pull request created: #76449

In response to this:

/cherrypick rhacs-docs-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced May 23, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 23, 2024

@kcarmichael08: new pull request created: #76450

In response to this:

/cherrypick rhacs-docs-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 23, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 23, 2024

@kcarmichael08: new pull request created: #76451

In response to this:

/cherrypick rhacs-docs-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

+1 more reviewer

@srcporter srcporter srcporter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@agantony @openshift-ci-robot @ocpdocs-previewbot @srcporter @kcarmichael08 @openshift-cherrypick-robot