Skip to content

Conversation

@kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Jun 7, 2024

Version(s):

RHACS 4.5+

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

See also #65388

Do we need changes to the Operator section? (I don't think so, but wanted to check.) https://77179--ocpdocs-pr.netlify.app/openshift-acs/latest/upgrading/upgrade-operator

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2024

@kcarmichael08: This pull request references ROX-24162 which is a valid jira issue.

In response to this:

Version(s):

RHACS 4.5+

Issue

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

See also #65388

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 7, 2024

🤖 Tue Jun 11 19:44:34 - Prow CI generated the docs preview:

https://77179--ocpdocs-pr.netlify.app/openshift-acs/latest/upgrading/upgrade-helm.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2024

@kcarmichael08: This pull request references ROX-24162 which is a valid jira issue.

In response to this:

Version(s):

RHACS 4.5+

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

See also #65388

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2024

@kcarmichael08: This pull request references ROX-24162 which is a valid jira issue.

In response to this:

Version(s):

RHACS 4.5+

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

See also #65388

Do we need changes to the Operator section? (I don't think so, but wanted to check.) https://77179--ocpdocs-pr.netlify.app/openshift-acs/latest/upgrading/upgrade-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 requested a review from msugakov June 7, 2024 18:00
Copy link

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this Kerry!

The operator is covered by that part

When upgrading Operator-based Central deployments from version 3.74, first ensure the Operator upgrade mode is set to Manual. Then, upgrade the Operator to version 4.0 following the procedure in the upgrade documentation for version 4.0 and ensure that Central is online. After the upgrade to version 4.0 is complete, Red Hat recommends upgrading Central to the latest version for full functionality.

and so we don't need to write anything extra.

@kcarmichael08 kcarmichael08 added rhacs-docs-4.5 peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 10, 2024
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 10, 2024
@mletalie
Copy link
Contributor

Hello @kcarmichael08,
Hope all is well! I know that the suggestion I made was not part of the scope you changed, but it may be worth updating to match what you did. Your call!

Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress
/lgtm


When upgrading from earlier releases, follow this guidance:

* If the release for Central is earlier than 3.74, you must upgrade to the latest 3.74 patch before upgrading to a 4.x release. See the link:https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_security_for_kubernetes/3.74/html/upgrading/index[upgrade documentation for version 3.74] for information about upgrades from earlier versions to 3.74.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* If the release for Central is earlier than 3.74, you must upgrade to the latest 3.74 patch before upgrading to a 4.x release. See the link:https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_security_for_kubernetes/3.74/html/upgrading/index[upgrade documentation for version 3.74] for information about upgrades from earlier versions to 3.74.
* If the release for Central is earlier than 3.74, you must upgrade to the latest 3.74 patch before upgrading to a 4.x release. See the link:https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_security_for_kubernetes/3.74/html/upgrading/index[upgrade documentation for version 3.74] for information about upgrades from earlier versions through 3.74.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking about it, I think "to" is better than "through" since the documentation being referred to describes upgrading to 3.74 and not any other versions before 3.74.... Basically, everyone needs to upgrade to a minimum of 3.74 before then upgrading to 4.0+ (there is no 3.75). I hope that makes sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I do appreciate the suggestions and the peer review though!

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 10, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2024

@kcarmichael08: This pull request references ROX-24162 which is a valid jira issue.

In response to this:

Version(s):

RHACS 4.5+

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

See also #65388

Do we need changes to the Operator section? (I don't think so, but wanted to check.) https://77179--ocpdocs-pr.netlify.app/openshift-acs/latest/upgrading/upgrade-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-24162-upgrade-4.5 branch from c3ce30d to 3aec0a6 Compare June 11, 2024 19:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2024

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit 7feb143 into openshift:rhacs-docs-main Jun 11, 2024
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.5

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #77333

In response to this:

/cherrypick rhacs-docs-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR rhacs-docs-4.5 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants