-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ROX-19617: Update policy info #77200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-19617: Update policy info #77200
Conversation
|
@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Fri Jul 19 17:33:17 - Prow CI generated the docs preview: https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/default-security-policies.html |
2292e2e to
3be85d5
Compare
3be85d5 to
1078348
Compare
|
@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1078348 to
95328a6
Compare
95328a6 to
578e077
Compare
|
@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1042636 to
0868fed
Compare
| | Container Memory Request | ||
| | Check for the amount of memory reserved for a given resource. | ||
| | Number, including fraction, of MB requested. | ||
| // Do we convert the K8s resource into MB (including convert MiB to MB) ? If so, the documentation should explain this conversion . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for tech reviewers here ^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to check.
|
@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
0868fed to
9f6087b
Compare
9f6087b to
68e8a2d
Compare
|
@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
68e8a2d to
d374792
Compare
clickboo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits.
| | Container Memory Request | ||
| | Check for the amount of memory reserved for a given resource. | ||
| | Number, including fraction, of MB requested. | ||
| // Do we convert the K8s resource into MB (including convert MiB to MB) ? If so, the documentation should explain this conversion . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to check.
|
/label peer-review-in-progress |
|
/label peer-review-done |
|
@kcarmichael08, Nice work! provided some suggestions for your consideration. Thanks |
d374792 to
50b66e7
Compare
50b66e7 to
83962d1
Compare
|
@kcarmichael08: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick rhacs-docs-4.4 |
|
/cherrypick rhacs-docs-4.5 |
|
@kcarmichael08: new pull request created: #79142 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kcarmichael08: new pull request created: #79143 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.4+
Issues:
https://issues.redhat.com/browse/ROX-19617
Links to docs previews:
https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/default-security-policies.html
https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-security-policies.html#policy-criteria_manage-security-policies
QE review:
Additional information:
Technical reviewers: Please see question in comments at the end of PR - thank you!