Skip to content

Conversation

@kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Jun 7, 2024

Version(s):

4.4+

Issues:

https://issues.redhat.com/browse/ROX-19617

Links to docs previews:

https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/default-security-policies.html
https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-security-policies.html#policy-criteria_manage-security-policies

QE review:

  • QE has approved this change.

Additional information:

Technical reviewers: Please see question in comments at the end of PR - thank you!

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2024

@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue.

In response to this:

Version(s):

4.4+

Issues:

https://issues.redhat.com/browse/ROX-23501
https://issues.redhat.com/browse/ROX-19617

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 7, 2024

@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from 2292e2e to 3be85d5 Compare June 7, 2024 20:22
@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from 3be85d5 to 1078348 Compare June 17, 2024 15:02
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2024

@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue.

In response to this:

Version(s):

4.4+

Issues:

https://issues.redhat.com/browse/ROX-19617

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 18, 2024

@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue.

In response to this:

Version(s):

4.4+

Issues:

https://issues.redhat.com/browse/ROX-19617

Links to docs previews:

https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/default-security-policies.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from 1078348 to 95328a6 Compare June 18, 2024 19:17
@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from 95328a6 to 578e077 Compare June 26, 2024 18:29
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 26, 2024

@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue.

In response to this:

Version(s):

4.4+

Issues:

https://issues.redhat.com/browse/ROX-19617

Links to docs previews:

https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/default-security-policies.html
https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-security-policies.html#policy-criteria_manage-security-policies

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch 2 times, most recently from 1042636 to 0868fed Compare July 3, 2024 19:53
| Container Memory Request
| Check for the amount of memory reserved for a given resource.
| Number, including fraction, of MB requested.
// Do we convert the K8s resource into MB (including convert MiB to MB) ? If so, the documentation should explain this conversion .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for tech reviewers here ^^^

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to check.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2024

@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue.

In response to this:

Version(s):

4.4+

Issues:

https://issues.redhat.com/browse/ROX-19617

Links to docs previews:

https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/default-security-policies.html
https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-security-policies.html#policy-criteria_manage-security-policies

QE review:

  • QE has approved this change.

Additional information:

Technical reviewers: Please see questions in comments at the end of PR - thank you!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from 0868fed to 9f6087b Compare July 3, 2024 20:05
@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from 9f6087b to 68e8a2d Compare July 15, 2024 13:43
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2024

@kcarmichael08: This pull request references ROX-19617 which is a valid jira issue.

In response to this:

Version(s):

4.4+

Issues:

https://issues.redhat.com/browse/ROX-19617

Links to docs previews:

https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/default-security-policies.html
https://77200--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-security-policies.html#policy-criteria_manage-security-policies

QE review:

  • QE has approved this change.

Additional information:

Technical reviewers: Please see question in comments at the end of PR - thank you!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 17, 2024
@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from 68e8a2d to d374792 Compare July 17, 2024 13:46
@kcarmichael08 kcarmichael08 added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 rhacs-docs-4.5 labels Jul 17, 2024
Copy link

@clickboo clickboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits.

| Container Memory Request
| Check for the amount of memory reserved for a given resource.
| Number, including fraction, of MB requested.
// Do we convert the K8s resource into MB (including convert MiB to MB) ? If so, the documentation should explain this conversion .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to check.

@shipsing
Copy link
Contributor

shipsing commented Jul 18, 2024

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 18, 2024
@shipsing
Copy link
Contributor

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 18, 2024
@shipsing
Copy link
Contributor

@kcarmichael08, Nice work! provided some suggestions for your consideration. Thanks

@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from d374792 to 50b66e7 Compare July 19, 2024 14:41
@kcarmichael08 kcarmichael08 removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 19, 2024
@kcarmichael08 kcarmichael08 force-pushed the ROX-19617-policy-updates branch from 50b66e7 to 83962d1 Compare July 19, 2024 17:29
@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2024

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit 25d9bbb into openshift:rhacs-docs-main Jul 19, 2024
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.4

@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.5

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #79142

In response to this:

/cherrypick rhacs-docs-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #79143

In response to this:

/cherrypick rhacs-docs-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 rhacs-docs-4.5 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants