Skip to content

Conversation

@tmalove
Copy link
Contributor

@tmalove tmalove commented Jun 11, 2024

Jira: OCPBUGS-35239

Version(s):
This PR is based on the ‘opp-docs-main’ repo and when merged, it should be in that branch only. The OPP doc is not versioned. Add this PR to the ‘Continuous Release’ milestone.

Link to docs preview:
Architecture Updated 6/26/2024)

QE review:

  • [x ] QE has approved this change. (Oded R.)

Additional information:
The product versions that are listed might not be the latest available version for the product. The versions listed in the compatibility matrix are the latest verified versions for OPP.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 11, 2024

🤖 Mon Jul 29 19:00:18 - Prow CI generated the docs preview:

https://77314--ocpdocs-pr.netlify.app/openshift-opp/latest/architecture/opp-architecture.html

@tmalove
Copy link
Contributor Author

tmalove commented Jun 12, 2024

/retest

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2024
@tmalove
Copy link
Contributor Author

tmalove commented Jun 18, 2024

@gparvin Will you take a look at the compatibility matrix ? I added the support product versions back to 4.12, but not sure if these versions were actually verified based on the OCP version. I will send Oded a DM since I could not find his @ in GH. Thanks!

Also, the architectural update diagram updates are coming soon.

:ocp-supported-version: 4.16
:rhacs-version: 4.5
:quay-version: 3.12
:rhacm-version: 2.10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have an ACM 2.11 release that will be available not long after OCP 4.16 is available. That is the one that should be listed here.

:ocp-supported-version-3: 4.13
:rhacs-version-3: 4.0
:quay-version-3: 3.8
:rhacm-version-3: 2.7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have had ACM 2.8 here. Can you double check to see when we documented ACM 2.8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gparvin after looking at the previous PRs to update the versions, 2.8 follows the trend, however, I will have Oded verify this. Thank you!

@tmalove tmalove changed the title [OCPBUGS#35239]: Update architecture diagram and compatibility table [OCPBUGS#35239]: Update the compatibility table Jul 3, 2024
@tmalove tmalove changed the title [OCPBUGS#35239]: Update the compatibility table [OCPBUGS#35239]: Update the compatibility matrix Jul 3, 2024
@tmalove
Copy link
Contributor Author

tmalove commented Jul 3, 2024

/retest

@tmalove
Copy link
Contributor Author

tmalove commented Jul 3, 2024

@gparvin I modified the original scope of this PR from Updating the architecture overview document and modifying the compatibility matrix to just the matrix updates. I will open a PR for updating the diagram when those changes are underway.
In the meantime, will you ack the matrix changes? You and Oded agreed that ACM 2.8 was verified with OCP 4.13. Thanks!

Copy link

@gparvin gparvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.

@tmalove
Copy link
Contributor Author

tmalove commented Jul 8, 2024

/label do-not-merge/hold

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2024

@tmalove: The label(s) /label do-not-merge/hold cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label do-not-merge/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmalove
Copy link
Contributor Author

tmalove commented Jul 29, 2024

/retest

@tmalove tmalove force-pushed the opp-osdocs-35239-tlove branch from 3709cbc to ce0eea9 Compare July 29, 2024 18:52
@tmalove
Copy link
Contributor Author

tmalove commented Jul 29, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 29, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2024

@tmalove: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 29, 2024
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 29, 2024
@tmalove
Copy link
Contributor Author

tmalove commented Jul 29, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 29, 2024
@opayne1 opayne1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 30, 2024
@opayne1 opayne1 added this to the Continuous Release milestone Jul 30, 2024
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@opayne1 opayne1 merged commit 6c3b150 into openshift:opp-docs-main Jul 30, 2024
@tmalove tmalove deleted the opp-osdocs-35239-tlove branch July 31, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants