OSDOCS - CNV-38323: Reverting a bug fix description in the RNs #78023

jherrman · 2024-06-25T13:22:20Z

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/CNV-38323

Link to docs preview:
https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html

QE review:

QE has approved this change.

openshift-ci-robot · 2024-06-25T13:22:25Z

@jherrman: This pull request references CNV-38323 which is a valid jira issue.

In response to this:

Version(s):
4.14 (and possibly 4.15 as well)

Issue:
https://issues.redhat.com/browse/CNV-38323

Link to docs preview:
TBA

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2024-06-25T13:30:41Z

🤖 Wed Sep 04 09:43:15 - Prow CI generated the docs preview:

https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html

openshift-ci-robot · 2024-06-25T17:07:47Z

@jherrman: This pull request references CNV-38323 which is a valid jira issue.

In response to this:

Version(s):
4.14 (and possibly 4.15 as well)

Issue:
https://issues.redhat.com/browse/CNV-38323

Link to docs preview:
https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jherrman · 2024-07-02T11:49:53Z

Note - As confirmed by Nijin in https://issues.redhat.com/browse/CNV-38323 , this should be applied to enterprise-4.14 as well (most likely via cherry-pick after the initial merge)

jherrman · 2024-07-03T13:21:34Z

/label peer-review-needed

dfitzmau · 2024-07-03T15:31:20Z

/remove-label peer-review-needed

/label peer-review-in-progress

dfitzmau · 2024-07-03T15:33:05Z

Hi @jherrman . The merger would need to know for sure if 4.15 is impacted. Can you confirm? Bug was fixed in 4.16?

dfitzmau

/remove-label peer-review-in-progress

/label peer-review-done

dfitzmau · 2024-07-03T15:37:54Z

virt/release_notes/virt-4-14-release-notes.adoc

 * Uninstalling {VirtProductName} does not remove the `feature.node.kubevirt.io` node labels created by {VirtProductName}. You must remove the labels manually. (link:https://issues.redhat.com/browse/CNV-22036[*CNV-22036*])

+//BZ 2151169
+* In a heterogeneous cluster with different compute nodes, virtual machines that have HyperV Reenlightenment enabled cannot be scheduled on nodes that do not support timestamp-counter scaling (TSC) or have the appropriate TSC frequency. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2151169[*BZ#2151169*])


Suggested change

* In a heterogeneous cluster with different compute nodes, virtual machines that have HyperV Reenlightenment enabled cannot be scheduled on nodes that do not support timestamp-counter scaling (TSC) or have the appropriate TSC frequency. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2151169[*BZ#2151169*])

* In a heterogeneous cluster with different compute nodes, virtual machines that have HyperV reenlightenment enabled cannot be scheduled on nodes that do not support timestamp-counter scaling (TSC) or have the appropriate TSC frequency. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2151169[*BZ#2151169*])

Lowercase according to link.

Good catch, fixed now

jherrman · 2024-07-22T15:03:38Z

Hi @jherrman . The merger would need to know for sure if 4.15 is impacted. Can you confirm? Bug was fixed in 4.16?

@dfitzmau SME confirmed in https://issues.redhat.com/browse/CNV-38323 that the issue impacts 4.15 and 4.16 as well (and possibly will for 4.17, too).

dfitzmau · 2024-07-22T15:16:14Z

Thanks, @jherrman . LGTM. WOuld you be OK to update the following description item to state "4.14+"?

openshift-ci-robot · 2024-07-23T11:23:02Z

@jherrman: This pull request references CNV-38323 which is a valid jira issue.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/CNV-38323

Link to docs preview:
https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jherrman · 2024-07-23T15:02:41Z

Thanks, @jherrman . LGTM. WOuld you be OK to update the following description item to state "4.14+"?

Done, thank you for the heads-up :-)

dshchedr · 2024-08-09T16:21:27Z

/lgtm

jherrman · 2024-08-12T13:16:29Z

/label merge-review-needed

jab-rh · 2024-08-12T14:24:02Z

@jherrman, if this is intended for 4.14+, I think this should be a PR against the main branch and not the enterprise-4.14 branch? Thanks!

openshift-ci-robot · 2024-08-12T15:27:30Z

@jherrman: This pull request references CNV-38323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/CNV-38323

Link to docs preview:
https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-08-12T15:31:11Z

@jherrman: This pull request references CNV-38323 which is a valid jira issue.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/CNV-38323

Link to docs preview:
https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jherrman · 2024-08-12T15:59:42Z

@jherrman, if this is intended for 4.14+, I think this should be a PR against the main branch and not the enterprise-4.14 branch? Thanks!

@jab-rh , my apologies, must have missed that in the OpenShift docs manual. Still, is it necessary? Changing the base branch to "main" complicates the PR quite a lot (due to the many added commits), and it's just a single very simple change, which should be easy to cherry-pick to other branches.

jab-rh · 2024-08-13T16:30:58Z

@kalexand-rh, can this be cherry-picked around from enterprise-4.14 or should this be re-done against main? Thanks!

kalexand-rh · 2024-09-03T12:25:18Z

It's not one of the repo best practices to cherry-pick to main, but if you can find a merge reviewer who is willing to make sure that no other changes creep into other branches, you can.

jherrman · 2024-09-03T14:44:35Z

Thank you for the info Kathryn!

However, one thing I did not realize earlier is that as an update to Release Notes, this cannot really be merged into Main. Also, as a bug fix description becoming a known issue description, it cannot be easily cherry-picked to the newer branches without conflict (since the newer branches don't contain the original bug fix).

So, this PR should still cover 4.14 (I changed the original description to reflect that) and I created a new one for 4.15 - 4.17: #78023 - which should theoretically be cherry-pickable without much trouble

Hopefully this does the trick, apologies for the shenanigans...

jab-rh · 2024-09-03T20:22:47Z

@jherrman, can you squad the commits for this PR? Thank you!

Moved BZ#2151169 into a specific node section Fixing up a capitalization issue

openshift-ci · 2024-09-04T09:31:52Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2024-09-04T09:45:09Z

@jherrman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jherrman · 2024-09-06T12:36:10Z

/label merge-review-needed

sheriff-rh

LGTM, merging.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 25, 2024

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2024

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 3, 2024

openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 3, 2024

dfitzmau approved these changes Jul 3, 2024

View reviewed changes

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 3, 2024

openshift-ci bot assigned dshchedr Aug 9, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 12, 2024

jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 12, 2024

jherrman changed the base branch from enterprise-4.14 to main August 12, 2024 15:27

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024

jherrman changed the base branch from main to enterprise-4.14 August 12, 2024 15:28

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024

jherrman mentioned this pull request Sep 3, 2024

OSDOCS#38323: Adding BZ#2151169 to known issues in 4.17 #81240

Merged

1 task

jab-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 3, 2024

BZ#2151169 bug fix -> known issue

6bc0320

Moved BZ#2151169 into a specific node section Fixing up a capitalization issue

jherrman force-pushed the CNV-38323 branch from 0f92c87 to 6bc0320 Compare September 4, 2024 09:31

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024

This was referenced Sep 6, 2024

OSDOCS#38323: Added a description for KI - BZ#2151169 #81408

Merged

OSDOCS#38323: Adding a description for KI #2151169 #81422

Merged

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 6, 2024

sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 6, 2024

sheriff-rh approved these changes Sep 6, 2024

View reviewed changes

sheriff-rh merged commit 1c82017 into openshift:enterprise-4.14 Sep 6, 2024

jab-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 15, 2024

	* In a heterogeneous cluster with different compute nodes, virtual machines that have HyperV Reenlightenment enabled cannot be scheduled on nodes that do not support timestamp-counter scaling (TSC) or have the appropriate TSC frequency. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2151169[BZ#2151169])
	* In a heterogeneous cluster with different compute nodes, virtual machines that have HyperV reenlightenment enabled cannot be scheduled on nodes that do not support timestamp-counter scaling (TSC) or have the appropriate TSC frequency. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2151169[BZ#2151169])

OSDOCS - CNV-38323: Reverting a bug fix description in the RNs #78023

OSDOCS - CNV-38323: Reverting a bug fix description in the RNs #78023

Uh oh!

Conversation

jherrman commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 25, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 25, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jherrman commented Jul 2, 2024

Uh oh!

jherrman commented Jul 3, 2024

Uh oh!

dfitzmau commented Jul 3, 2024

Uh oh!

dfitzmau commented Jul 3, 2024

Uh oh!

dfitzmau left a comment

Choose a reason for hiding this comment

Uh oh!

dfitzmau Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

jherrman Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

jherrman commented Jul 22, 2024

Uh oh!

dfitzmau commented Jul 22, 2024

Uh oh!

openshift-ci-robot commented Jul 23, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jherrman commented Jul 23, 2024

Uh oh!

dshchedr commented Aug 9, 2024

Uh oh!

jherrman commented Aug 12, 2024

Uh oh!

jab-rh commented Aug 12, 2024

Uh oh!

openshift-ci-robot commented Aug 12, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 12, 2024

Uh oh!

jherrman commented Aug 12, 2024

Uh oh!

jab-rh commented Aug 13, 2024

Uh oh!

kalexand-rh commented Sep 3, 2024

Uh oh!

jherrman commented Sep 3, 2024

Uh oh!

jab-rh commented Sep 3, 2024

Uh oh!

openshift-ci bot commented Sep 4, 2024

Uh oh!

openshift-ci bot commented Sep 4, 2024

Uh oh!

jherrman commented Sep 6, 2024

Uh oh!

sheriff-rh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jherrman commented Jun 25, 2024 •

edited

Loading

openshift-ci-robot commented Jun 25, 2024 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Jun 25, 2024 •

edited

Loading

openshift-ci-robot commented Jun 25, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 23, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 12, 2024 •

edited by openshift-ci bot

Loading