Skip to content

Conversation

@agantony
Copy link
Contributor

@agantony agantony commented Jul 3, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2024

@agantony: This pull request references ROX-24807 which is a valid jira issue.

In response to this:

Version(s):
4.4

Issue:
https://issues.redhat.com/browse/ROX-24807

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2024
@agantony
Copy link
Contributor Author

agantony commented Jul 3, 2024

/label RHACS

@openshift-ci openshift-ci bot added the RHACS Label for RHACS related PRs that go in the rhacs-docs branch label Jul 3, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 3, 2024

🤖 Mon Jul 08 09:44:26 - Prow CI generated the docs preview:
https://78410--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 3, 2024

@agantony: This pull request references ROX-24807 which is a valid jira issue.

In response to this:

Version(s):
4.4

Issue:
https://issues.redhat.com/browse/ROX-24807

Link to docs preview:
https://78410--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/44-release-notes#resolved-in-version-444_release-notes-44

SME review:

  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony force-pushed the ROX24807-rhacs-docs-4.4 branch from 2ae83fc to 2dd9ced Compare July 8, 2024 09:29
@agantony
Copy link
Contributor Author

agantony commented Jul 8, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 8, 2024
ROX24807 SME feedback

ROX24807 SME feedback

ROX24807 Minor adjustments
@agantony agantony force-pushed the ROX24807-rhacs-docs-4.4 branch from 2dd9ced to c6efb39 Compare July 8, 2024 09:38
@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2024

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 8, 2024
@adellape adellape self-assigned this Jul 8, 2024
@adellape adellape added this to the Continuous Release milestone Jul 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2024

@agantony: This pull request references ROX-24807 which is a valid jira issue.

In response to this:

Version(s):
4.4

Issue:
https://issues.redhat.com/browse/ROX-24807

Link to docs preview:
https://78410--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/44-release-notes#resolved-in-version-444_release-notes-44

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony
Copy link
Contributor Author

agantony commented Jul 9, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2024

@agantony: This pull request references ROX-24807 which is a valid jira issue.

In response to this:

Version(s):
4.4

Issue:
https://issues.redhat.com/browse/ROX-24807

Link to docs preview:
https://78410--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/44-release-notes#resolved-in-version-444_release-notes-44

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, merging.

@sheriff-rh sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 9, 2024
@sheriff-rh sheriff-rh merged commit 56ddd51 into openshift:rhacs-docs-4.4 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants