Skip to content

Conversation

@fabianvf
Copy link
Member

@fabianvf fabianvf commented Feb 20, 2018

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2018
@fabianvf
Copy link
Member Author

ping @sdodson , any idea who should review this?

@vikram-redhat
Copy link
Contributor

@adellape - does this still need inclusion in the docs? Otherwise, can you close it?

@sdodson
Copy link
Member

sdodson commented Mar 21, 2018

Yes we need it.

@ahardin-rh
Copy link
Contributor

I'm now assigned to https://bugzilla.redhat.com/show_bug.cgi?id=1546247. Overall, this PR looks good to me. I can make some minor style edits in a follow-up PR.

I labeled this for 3.6+ is that correct? Requesting QE review before we merge. Thanks!

@sdodson
Copy link
Member

sdodson commented Apr 2, 2018

Yes, it's relevant for pretty much any version of openshift.

@ahardin-rh ahardin-rh merged commit f6b25ec into openshift:master Apr 4, 2018
@ahardin-rh
Copy link
Contributor

QE verfied in the BZ

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.9

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #8579

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.10

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #8580

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.7

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #8581

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.6

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #8582

In response to this:

/cherrypick enterprise-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.5

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #8583

In response to this:

/cherrypick enterprise-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants