Skip to content

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Jul 11, 2024

Version(s):

GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

The following links were broken in the Post GA content verification for the GitOps 1.13 release, which is published in docs.redhat.com. The broken link instances have been fixed now and can be viewed in the following preview links:

Installing the logging subsystem for Red Hat OpenShift using the web console
Enabled for user-defined projects
GITOPS-1767
About the Cloud Credential Operator

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

https://78772--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/logging/viewing-argo-cd-logs.html
https://78772--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-argo-cd-custom-resource-workloads.html
https://78772--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes.html
https://78772--ocpdocs-pr.netlify.app/openshift-gitops/latest/securing_openshift_gitops/managing-secrets-securely-using-sscsid-with-gitops.html

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

https://78772--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/logging/viewing-argo-cd-logs.html
Enabled for user-defined projects
https://78772--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes.html
https://78772--ocpdocs-pr.netlify.app/openshift-gitops/latest/securing_openshift_gitops/managing-secrets-securely-using-sscsid-with-gitops.html

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

Installing the logging subsystem for Red Hat OpenShift using the web console
Enabled for user-defined projects
GITOPS-1767
About the Cloud Credential Operatorhttps://78772--ocpdocs-pr.netlify.app/openshift-gitops/latest/securing_openshift_gitops/managing-secrets-securely-using-sscsid-with-gitops.html

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

Installing the logging subsystem for Red Hat OpenShift using the web console
Enabled for user-defined projects
GITOPS-1767
About the Cloud Credential Operator

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

The following links were broken in the Post GA content verification of the GitOps 1.13 content published in docs.redhat.com. They have been fixed now and can be viewed in the following preview:

Installing the logging subsystem for Red Hat OpenShift using the web console
Enabled for user-defined projects
GITOPS-1767
About the Cloud Credential Operator

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

The following links were broken in the Post GA content verification for the GitOps 1.13 release, which is published in docs.redhat.com. The broken link instances have been fixed now and can be viewed in the following preview links:

Installing the logging subsystem for Red Hat OpenShift using the web console
Enabled for user-defined projects
GITOPS-1767
About the Cloud Credential Operator

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@varshab1210
Copy link

LGTM

@Dhruv-Soni11
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 15, 2024
@Srivaralakshmi Srivaralakshmi added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 15, 2024
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 Thanks for the corrections. Left some suggestions. PTAL.

@Srivaralakshmi Srivaralakshmi added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
Copy link

openshift-ci bot commented Jul 15, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2024
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 Please pay attention to the review comments and address them completely. Thanks!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

The following links were broken in the Post GA content verification for the GitOps 1.13 release, which is published in docs.redhat.com. The broken link instances have been fixed now and can be viewed in the following preview links:

Installing the logging subsystem for Red Hat OpenShift using the web console
Enabled for user-defined projects
GITOPS-1767
About the Cloud Credential Operator

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5827

Link to docs preview:

The following links were broken in the Post GA content verification for the GitOps 1.13 release, which is published in docs.redhat.com. The broken link instances have been fixed now and can be viewed in the following preview links:

Installing the logging subsystem for Red Hat OpenShift using the web console
Enabled for user-defined projects
GITOPS-1767
About the Cloud Credential Operator

QE review:

  • QE has approved this change.

SME review: @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 LGTM. Thanks!

@Srivaralakshmi Srivaralakshmi added lgtm Indicates that a PR is ready to be merged. gitops labels Jul 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
Copy link

openshift-ci bot commented Jul 15, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Jul 15, 2024

@Dhruv-Soni11: The label(s) /label merge-request-needed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label merge-request-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 15, 2024
@Srivaralakshmi Srivaralakshmi added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 15, 2024
Copy link

openshift-ci bot commented Jul 15, 2024

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Srivaralakshmi Srivaralakshmi merged commit 4f00708 into openshift:gitops-docs-main Jul 15, 2024
@Srivaralakshmi
Copy link
Contributor

/cherrypick gitops-docs-1.11

@Srivaralakshmi
Copy link
Contributor

/cherrypick gitops-docs-1.12

@Srivaralakshmi
Copy link
Contributor

/cherrypick gitops-docs-1.13

@openshift-cherrypick-robot

@Srivaralakshmi: #78772 failed to apply on top of branch "gitops-docs-1.11":

Applying: RHDEVDOCS-5827: Fixing broken or incorrect links in GitOps 1.13
Using index info to reconstruct a base tree...
M	observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
Falling back to patching base and 3-way merge...
Auto-merging observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
CONFLICT (content): Merge conflict in observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5827: Fixing broken or incorrect links in GitOps 1.13
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@Srivaralakshmi: #78772 failed to apply on top of branch "gitops-docs-1.13":

Applying: RHDEVDOCS-5827: Fixing broken or incorrect links in GitOps 1.13
Using index info to reconstruct a base tree...
M	observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
Falling back to patching base and 3-way merge...
Auto-merging observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
CONFLICT (content): Merge conflict in observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5827: Fixing broken or incorrect links in GitOps 1.13
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@Srivaralakshmi: new pull request created: #78882

In response to this:

/cherrypick gitops-docs-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants