-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-5827: Fixing broken or incorrect links in GitOps 1.13 #78772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-5827: Fixing broken or incorrect links in GitOps 1.13 #78772
Conversation
@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7f67ecd
to
a4a63d3
Compare
@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruv-Soni11 Thanks for the corrections. Left some suggestions. PTAL.
observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
Show resolved
Hide resolved
a4a63d3
to
41d23de
Compare
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruv-Soni11 Please pay attention to the review comments and address them completely. Thanks!
observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
Show resolved
Hide resolved
observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
Show resolved
Hide resolved
41d23de
to
65cf67e
Compare
@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5827 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
65cf67e
to
a83582d
Compare
observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/monitoring-argo-cd-custom-resource-workloads.adoc
Outdated
Show resolved
Hide resolved
a83582d
to
f320d20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruv-Soni11 LGTM. Thanks!
f320d20
to
9a2b835
Compare
New changes are detected. LGTM label has been removed. |
@Dhruv-Soni11: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label merge-review-needed |
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick gitops-docs-1.11 |
/cherrypick gitops-docs-1.12 |
/cherrypick gitops-docs-1.13 |
@Srivaralakshmi: #78772 failed to apply on top of branch "gitops-docs-1.11":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Srivaralakshmi: #78772 failed to apply on top of branch "gitops-docs-1.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Srivaralakshmi: new pull request created: #78882 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5827
Link to docs preview:
The following links were broken in the Post GA content verification for the GitOps 1.13 release, which is published in docs.redhat.com. The broken link instances have been fixed now and can be viewed in the following preview links:
Installing the logging subsystem for Red Hat OpenShift using the web console
Enabled for user-defined projects
GITOPS-1767
About the Cloud Credential Operator
QE review:
SME review: @svghadi
QE review: @varshab1210
Peer review:
Additional information: