WIP OADP-4610: Fix name keypair value oadp dpa

[anarnold97]

Jira

• OADP-4610

Version(s):

Issue:

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4610 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Jira

• OADP-4610

Version(s):

Issue:

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Tue Jul 30 10:59:38 - Prow CI generated the docs preview:

https://79643--ocpdocs-pr.netlify.app/openshift-dedicated/latest/virt/backup_restore/virt-backup-restore-overview.html
https://79643--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-aws.html
https://79643--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-azure.html
https://79643--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.html
https://79643--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-kubevirt.html
https://79643--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.html
https://79643--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.html
https://79643--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/backup_restore/virt-backup-restore-overview.html
https://79643--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/backup_restore/virt-backup-restore-overview.html

[shdeshpa07]

@anarnold97 - LGTM. I have one question though, Prasad mentions in his comment in PR about 'name' key-value pair not being supported for VSL only. He doesn't say anything about removing it for BSL.

The changes in this PR remove 'name' from both BSL and VSL. Is that okay?

[shdeshpa07]

I looked at the DPA 1.2 and 1.3 for 4.14, 4.15 and 4.16 and found 'name' key value pair at the following locations:

4.14:

DPA 1.2:
name key-value pair in: aws bsl, azure vsl

DPA 1.3:
name key-value pair in: aws bsl and vsl, azure vsl

4.15:

DPA 1.2:
name key-value pair in: aws bsl, azure vsl

DPA 1.3:
name key-value pair in: aws bsl and vsl, azure vsl

4.16:

DPA 1.2:
name key-value pair in: aws bsl, azure vsl

DPA 1.3:
name key-value pair in: aws bsl and vsl, azure vsl

[anarnold97]

I looked at the DPA 1.2 and 1.3 for 4.14, 4.15 and 4.16 and found 'name' key value pair at the following locations:

4.14:

DPA 1.2: name key-value pair in: aws bsl, azure vsl

DPA 1.3: name key-value pair in: aws bsl and vsl, azure vsl

4.15:

DPA 1.2: name key-value pair in: aws bsl, azure vsl

DPA 1.3: name key-value pair in: aws bsl and vsl, azure vsl

4.16:

DPA 1.2: name key-value pair in: aws bsl, azure vsl

DPA 1.3: name key-value pair in: aws bsl and vsl, azure vsl

Please can you give me line numbers?

[shdeshpa07]

I looked at the DPA 1.2 and 1.3 for 4.14, 4.15 and 4.16 and found 'name' key value pair at the following locations:
4.14:
DPA 1.2: name key-value pair in: aws bsl, azure vsl
DPA 1.3: name key-value pair in: aws bsl and vsl, azure vsl
4.15:
DPA 1.2: name key-value pair in: aws bsl, azure vsl
DPA 1.3: name key-value pair in: aws bsl and vsl, azure vsl
4.16:
DPA 1.2: name key-value pair in: aws bsl, azure vsl
DPA 1.3: name key-value pair in: aws bsl and vsl, azure vsl

Please can you give me line numbers?

Here are the line numbers for VSL only:

4.14:

DPA 1.2: azure vsl line no. 152

DPA 1.3: aws vsl line 84, azure vsl line 153

4.15:

DPA 1.2: azure vsl line 152

DPA 1.3: aws vsl line 84, azure vsl line 153

4.16:

DPA 1.2: azure vsl line 152

DPA 1.3: aws vsl line 84, azure vsl line 153

[anarnold97]

@shdeshpa07 - please can you peer-review?
Thanks for the line numbers think we have it

[openshift-ci]

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[shdeshpa07]

@anarnold97 - LGTM. Thanks.

[anarnold97]

@PrasadJoshi12 - please could you review this PR to fix the VSL name?

Thanks

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.