Skip to content

Conversation

kalyaniverma
Copy link

This PR replaces specific task names and namespace names with placeholders in the Task run commands for better clarity

No new information is added. Therefore, no QE review is necessary.

Version(s):

Issue:

Link to docs preview:

QE review:

  • Not required (no changes impacting functionality)

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2024
Copy link

openshift-ci bot commented Sep 13, 2024

Hi @kalyaniverma. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2024
@Srivaralakshmi
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 16, 2024

🤖 Mon Sep 16 09:42:12 - Prow CI generated the docs preview:

https://81790--ocpdocs-pr.netlify.app/openshift-pipelines/latest/tkn_cli/op-tkn-reference.html

@Srivaralakshmi Srivaralakshmi changed the base branch from pipelines-docs-1.15 to pipelines-docs-main September 16, 2024 09:37
@openshift-ci openshift-ci bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2024
@Srivaralakshmi Srivaralakshmi changed the base branch from pipelines-docs-main to pipelines-docs-1.15 September 16, 2024 09:37
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2024
Copy link

openshift-ci bot commented Sep 16, 2024

@kalyaniverma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kalyaniverma I added two comments, for line 19 and 63 that need to be edited. The rest looks good.

However, there is one more issue, I notice you created your feature branch against pipelines-docs-1.15, it needs to be created against pipelines-docs-main. So you will have to create a new feature branch against the right branch and raise a new PR again. Please also incorporate the feedback I left.

Thank you! 🙂

== taskrun cancel
Cancel a task run.

.Example: Cancel the `mytaskrun` task run from a namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.Example: Cancel the `mytaskrun` task run from a namespace
.Example: Cancel a task run from a namespace

Display task run logs.

.Example: Display live logs for the `mytaskrun` task run in a namespace

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change a line 63 from:

.Example: Display live logs for the `mytaskrun` task run in a namespace

to:

.Example: Display live logs for a task run in a namespace

@Srivaralakshmi
Copy link
Contributor

Good job! I have a suggestion about the content type attribute. Please implement the suggestion given.

After L2, leave a line. Before L4, add this attribute:
:_mod-docs-content-type: REFERENCE

For more information, see: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#content-type-attributes and https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#module-file-metadata.

Thanks, @kalyaniverma.

@kalyaniverma kalyaniverma deleted the patch-1 branch October 1, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. pipelines size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants