PR for SRVLOGIC-310: Document "Job Service" section in the OSL docs

[kaldesai]

Affecting version:

• serverless-docs-1.34
• serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-310

Doc preview: Job service

[openshift-ci-robot]

@kaldesai: This pull request references SRVLOGIC-310 which is a valid jira issue.

In response to this:

Affecting version: serverless-docs-1.34

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-310

Doc preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Wed Oct 09 13:34:29 - Prow CI generated the docs preview:
https://81945--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

[openshift-ci-robot]

@kaldesai: This pull request references SRVLOGIC-310 which is a valid jira issue.

In response to this:

Affecting version:

• serverless-docs-1.34
• serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-310

Doc preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@kaldesai: This pull request references SRVLOGIC-310 which is a valid jira issue.

In response to this:

Affecting version:

• serverless-docs-1.34
• serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-310

Doc preview: Job service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wmedvede]

Hi @kaldesai ,
I have added some nitpicks, please take a look. I think we must incorporate independently if we go with a more reduced version of the jobs service section. If we go with the reduced version, we keep this work for the future/upcoming releases.

[kaldesai]

@wmedvede @domhanak @ricardozanini @gmunozfe

Let me verify once again do you want me to remove all of these sections from the PR and won't be there for 1.34?
include::modules/serverless-logic-job-service-custom-execution.adoc[leveloffset=+1]
include::modules/serverless-logic-job-service-common-config.adoc[leveloffset=+1]
include::modules/serverless-logic-job-service-postgresql-ephemeral-config.adoc[leveloffset=+1]
include::modules/serverless-logic-job-service-eventing-api-config.adoc[leveloffset=+1]

[wmedvede]

@wmedvede @domhanak @ricardozanini @gmunozfe

Let me verify once again do you want me to remove all of these sections from the PR and won't be there for 1.34? include::modules/serverless-logic-job-service-custom-execution.adoc[leveloffset=+1] include::modules/serverless-logic-job-service-common-config.adoc[leveloffset=+1] include::modules/serverless-logic-job-service-postgresql-ephemeral-config.adoc[leveloffset=+1] include::modules/serverless-logic-job-service-eventing-api-config.adoc[leveloffset=+1]

yes, "remove" becasue it was not possible to get that far with OSL 1.34.0. So we have to still only promote the Operator and not the Quarkus style. The content is good, so this is why I suggested to still apply the suggestions on these sections, and we keep it "buffered".

[kaldesai]

@wmedvede @ricardozanini @domhanak @@gmunozfe As per the suggestions I have removed the sections. Thank you!

[kaldesai]

/label peer-review-needed

[abhatt-rh]

/label peer-review-in-progress

[abhatt-rh]

Hi @kaldesai
Nice work! I have added some style and structure related comments fro your consideration.
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

[openshift-ci]

@kaldesai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kaldesai]

/label merge-review-needed

[adellape]

/cherrypick serverless-docs-1.34

[adellape]

/cherrypick serverless-docs-1.33

[openshift-cherrypick-robot]

@adellape: new pull request created: #83266

In response to this:

/cherrypick serverless-docs-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@adellape: #81945 failed to apply on top of branch "serverless-docs-1.33":

Applying: SRVLOGIC-310-Job-Service: Added a Job service section for serverless logic
.git/rebase-apply/patch:47: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A	serverless-logic/serverless-logic-supporting-services/serverless-logic-job-service.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): serverless-logic/serverless-logic-supporting-services/serverless-logic-job-service.adoc deleted in HEAD and modified in SRVLOGIC-310-Job-Service: Added a Job service section for serverless logic. Version SRVLOGIC-310-Job-Service: Added a Job service section for serverless logic of serverless-logic/serverless-logic-supporting-services/serverless-logic-job-service.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 SRVLOGIC-310-Job-Service: Added a Job service section for serverless logic

In response to this:

/cherrypick serverless-docs-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adellape]

@kaldesai serverless-docs-1.33 auto cherrypick failed and will need a manual cherrypick PR.

Probably related to changing the :ServerlessProductVersion: common attr.

[wmedvede]

Hello guys, @adellape @kaldesai , this one was merged by mistake?

I can't see any approval.