Skip to content

OCP monitoring 4.17 release notes #82009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

OCP monitoring 4.17 release notes #82009

merged 1 commit into from
Sep 25, 2024

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Sep 18, 2024 •
edited
Loading

Version(s): No CP, enterprise-4.17 only.

Issue: OBSDOCS-1196

Link to docs preview: https://82009--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-17-release-notes.html#ocp-4-17-monitoring_release-notes

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 18, 2024 •
edited
Loading

🤖 Wed Sep 25 13:20:20 - Prow CI generated the docs preview:

https://82009--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-17-release-notes.html

jan--f
jan--f approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
marioferh
marioferh reviewed Sep 23, 2024
View reviewed changes
Copy link

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@juzhao
Copy link

juzhao commented Sep 24, 2024

/lgtm

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 24, 2024
@xenolinux xenolinux added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 24, 2024
@xenolinux xenolinux added this to the Planned for 4.17 GA milestone Sep 24, 2024
xenolinux
xenolinux reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments; otherwise LGTM.

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 24, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 25, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 25, 2024
simonpasquier
simonpasquier reviewed Sep 25, 2024
View reviewed changes
Copy link

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 25, 2024
jeana-redhat
jeana-redhat approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, LGTM!

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@jeana-redhat jeana-redhat merged commit 0aa20b4 into openshift:enterprise-4.17 Sep 25, 2024
2 checks passed
@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 25, 2024
@eromanova97 eromanova97 deleted the OBSDOCS-1196 branch September 26, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

@jeana-redhat jeana-redhat jeana-redhat approved these changes

+3 more reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@marioferh marioferh marioferh left review comments

@jan--f jan--f jan--f approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jan--f jan--f

@simonpasquier simonpasquier

@juzhao juzhao

@marioferh marioferh

Labels

branch/enterprise-4.17 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.17 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@eromanova97 @ocpdocs-previewbot @juzhao @jan--f @simonpasquier @xenolinux @jeana-redhat @marioferh