Skip to content

Conversation

rh-tokeefe
Copy link
Contributor

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

https://issues.redhat.com/browse/OSSM-8195

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2024

@rh-tokeefe: This pull request references OSSM-8195 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

https://issues.redhat.com/browse/OSSM-8195

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2024
@rh-tokeefe rh-tokeefe changed the title OSSM-8195: Create docinfo.xml files for service mesh mirroring process [WIP] OSSM-8195: Create docinfo.xml files for service mesh mirroring process with Pantheon Sep 30, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2024
@stevsmit stevsmit added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 30, 2024
@stevsmit
Copy link
Member

stevsmit commented Sep 30, 2024

The doc info files look good to me. I've noted a few things that you might consider, some of which are applicable to all modules! Good work.

If you don't want to make these changes because they mirror the Service Mesh content somewhere else, no worries. None of these changes are required, and are really only small suggestions/things to consider.

@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 30, 2024
@stevsmit stevsmit added this to the Continuous Release milestone Sep 30, 2024
Copy link

openshift-ci bot commented Sep 30, 2024

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe rh-tokeefe changed the title [WIP] OSSM-8195: Create docinfo.xml files for service mesh mirroring process with Pantheon OSSM-8195: Create docinfo.xml files for service mesh mirroring process with Pantheon Oct 1, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2024
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabriel-rh gabriel-rh merged commit 7a9a5d9 into openshift:service-mesh-docs-main Oct 1, 2024
2 checks passed
@gabriel-rh
Copy link
Contributor

/cherrypick service-mesh-docs-3.0.0tp1

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #82767

In response to this:

/cherrypick service-mesh-docs-3.0.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants