Skip to content

OLS-1145: Document attaching a YAML file from the Networking page #83371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

OLS-1145: Document attaching a YAML file from the Networking page #83371

merged 1 commit into from
Oct 17, 2024

Conversation

@rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Oct 10, 2024 •
edited
Loading

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1145

Link to docs preview:
https://83371--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/operate/ols-using-openshift-lightspeed.html#ols-attaching-a-resource-object-to-your-query_ols-using-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2024 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1145 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1145

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 10, 2024 •
edited
Loading

🤖 Wed Oct 16 11:56:47 - Prow CI generated the docs preview:

https://83371--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/operate/ols-using-openshift-lightspeed.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1145 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1145

Link to docs preview:
https://83371--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/operate/ols-using-openshift-lightspeed.html#ols-attaching-a-resource-object-to-your-query_ols-using-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyoto
Copy link
Member

kyoto commented Oct 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
@JoaoFula
Copy link
Contributor

JoaoFula commented Oct 15, 2024

LGTM

@rh-tokeefe
Copy link
Contributor Author

rh-tokeefe commented Oct 15, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 15, 2024
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 15, 2024
skopacz1
skopacz1 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and a question, otherwise LGTM!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 16, 2024 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1145 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1145

Link to docs preview:
https://83371--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/operate/ols-using-openshift-lightspeed.html#ols-attaching-a-resource-object-to-your-query_ols-using-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2024

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe
Copy link
Contributor Author

rh-tokeefe commented Oct 17, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 17, 2024
lahinson
lahinson reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahinson lahinson removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 17, 2024
@lahinson lahinson merged commit fe5b19a into openshift:lightspeed-docs-main Oct 17, 2024
2 checks passed
@lahinson
Copy link
Contributor

lahinson commented Oct 17, 2024

/cherrypick lightspeed-docs-1.0tp1

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 17, 2024

@lahinson: new pull request created: #83695

In response to this:

/cherrypick lightspeed-docs-1.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahinson lahinson lahinson left review comments

@skopacz1 skopacz1 skopacz1 approved these changes

Assignees

@kyoto kyoto

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rh-tokeefe @openshift-ci-robot @ocpdocs-previewbot @kyoto @JoaoFula @lahinson @openshift-cherrypick-robot @skopacz1