ROX:26400: Update RHACS to use VEX #83406

kcarmichael08 · 2024-10-11T16:48:39Z

PLEASE READ "ADDITIONAL INFORMATION"

Version(s):
4.6+

Links to docs previews:

83406--ocpdocs-pr.netlify.app/openshift-acs/latest/architecture/acs-architecture.html
83406--ocpdocs-pr.netlify.app/openshift-acs/latest/cloud_service/acscs-architecture.html
83406--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/scan-rhcos-node-host.html

QE review: ACS has no QE, approved by SME

QE has approved this change.

Additional information:

Moved vulnerability sources into its own module.
See ROX-24197: [rhacs-docs-4.6] Update docs for RHCOS scanning with Scanner V4 #84256 for other Scanner V4 changes.

openshift-ci-robot · 2024-10-11T16:48:44Z

@kcarmichael08: This pull request references ROX-26400 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-11T16:50:17Z

@kcarmichael08: This pull request references ROX-26400 which is a valid jira issue.

In response to this:

PLEASE READ "ADDITIONAL INFORMATION"

Version(s):
4.6+

Issue

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Moved vulnerability sources into its own module.

This PR doesn't include changes for node scanning - see https://issues.redhat.com/browse/ROX-24197

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2024-10-11T16:58:35Z

🤖 Tue Nov 26 23:23:39 - Prow CI generated the docs preview:

https://83406--ocpdocs-pr.netlify.app/openshift-acs/latest/architecture/acs-architecture.html
https://83406--ocpdocs-pr.netlify.app/openshift-acs/latest/cloud_service/acscs-architecture.html
https://83406--ocpdocs-pr.netlify.app/openshift-acs/latest/configuration/enable-offline-mode.html
https://83406--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html
https://83406--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/scan-rhcos-node-host.html

openshift-ci-robot · 2024-10-11T17:08:27Z

@kcarmichael08: This pull request references ROX-26400 which is a valid jira issue.

In response to this:

PLEASE READ "ADDITIONAL INFORMATION"

Version(s):
4.6+

Issue

Links to docs previews:

83406--ocpdocs-pr.netlify.app/openshift-acs/latest/architecture/acs-architecture.html
83406--ocpdocs-pr.netlify.app/openshift-acs/latest/cloud_service/acscs-architecture.html
83406--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/scan-rhcos-node-host.html

QE review:

QE has approved this change.

Additional information:

Moved vulnerability sources into its own module.

This PR doesn't include changes for node scanning - see https://issues.redhat.com/browse/ROX-24197

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-11T17:19:14Z

@kcarmichael08: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

PLEASE READ "ADDITIONAL INFORMATION"

Version(s):
4.6+

Issue

Links to docs previews:

83406--ocpdocs-pr.netlify.app/openshift-acs/latest/architecture/acs-architecture.html
83406--ocpdocs-pr.netlify.app/openshift-acs/latest/cloud_service/acscs-architecture.html
83406--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/scan-rhcos-node-host.html

QE review:

QE has approved this change.

Additional information:

Moved vulnerability sources into its own module.

This PR doesn't include changes for node scanning - see https://issues.redhat.com/browse/ROX-24197

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RTann

left some comments. Biggest thing is I'm wondering if things might be clearer if we split the sources into separate StackRox Scanner and Scanner V4 sections

modules/con-vuln-sources.adoc

modules/rhcos-match-vulnerability.adoc

operating/manage-vulnerabilities/scan-rhcos-node-host.adoc

modules/con-vuln-sources.adoc

modules/rhcos-match-vulnerability.adoc

operating/manage-vulnerabilities/scan-rhcos-node-host.adoc

RTann

a few comments. Some of the URLs changed very recently so I commented the new ones

configuration/enable-offline-mode.adoc

modules/rhcos-match-vulnerability.adoc

modules/consolidated-scanner.adoc

modules/con-vuln-sources.adoc

modules/consolidated-scanner.adoc

modules/con-vuln-sources.adoc

kowen-rh · 2024-11-26T17:34:51Z

/remove-label peer-review-needed
/label peer-review-in-progress

kowen-rh

This looks great! I only have one comment, otherwise this looks good to me. 👍

/remove-label peer-review-in-progress
/label peer-review-done

kowen-rh · 2024-11-26T17:39:49Z

modules/con-vuln-sources.adoc

+
+[NOTE]
+====
+{product-title-short} uses the OSV database available at link:https://osv.dev/[OSV.dev] under link:https://github.com/google/osv.dev/blob/master/LICENSE[this license].


I think we should name it as the Apache license here.

RTann · 2024-11-26T22:51:30Z

operating/examine-images-for-vulnerabilities.adoc

 [NOTE]
 ====
-The {product-title-short} Scanner V4 uses the OSV database available at link:https://osv.dev/[OSV.dev] under link:https://github.com/google/osv.dev/blob/master/LICENSE[this license].
+The {product-title-short} Scanner V4 uses the OSV database available at link:https://osv.dev/[OSV.dev] under the link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache license].


Suggested change

The {product-title-short} Scanner V4 uses the OSV database available at link:https://osv.dev/[OSV.dev] under the link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache license].

The {product-title-short} Scanner V4 uses the OSV database available at link:https://osv.dev/[OSV.dev] under link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache License 2.0].

RTann · 2024-11-26T22:55:00Z

modules/con-vuln-sources.adoc

+
+[NOTE]
+====
+{product-title-short} uses the OSV database available at link:https://osv.dev/[OSV.dev] under the link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache license].


Suggested change

{product-title-short} uses the OSV database available at link:https://osv.dev/[OSV.dev] under the link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache license].

{product-title-short} uses the OSV database available at link:https://osv.dev/[OSV.dev] under link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache License 2.0].

RTann · 2024-11-26T22:56:18Z

approved for faster turnaround, but two changes requested

kcarmichael08 · 2024-11-26T23:08:53Z

approved for faster turnaround, but two changes requested

Got them in and will merge after it rebuilds.

openshift-ci · 2024-11-26T23:24:47Z

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kcarmichael08 · 2024-11-26T23:25:59Z

/cherrypick rhacs-docs-4.6

openshift-cherrypick-robot · 2024-11-26T23:26:51Z

@kcarmichael08: new pull request created: #85532

In response to this:

/cherrypick rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 11, 2024

openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2024

kcarmichael08 changed the title ~~ROX-26400: Update RHACS to use VEX~~ ROX:26400: Update RHACS to use VEX Oct 11, 2024

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 11, 2024

kcarmichael08 force-pushed the rox-26400-scanner-vex branch from 54f7c17 to 14f5d92 Compare October 11, 2024 17:19

RTann reviewed Oct 11, 2024

View reviewed changes

kcarmichael08 force-pushed the rox-26400-scanner-vex branch 3 times, most recently from 6de4b88 to dd2c8ec Compare October 25, 2024 17:30

RTann reviewed Oct 25, 2024

View reviewed changes

kcarmichael08 force-pushed the rox-26400-scanner-vex branch 2 times, most recently from d40d105 to 646000c Compare October 28, 2024 20:48

kcarmichael08 added the rhacs-docs-4.6 label Oct 31, 2024

kcarmichael08 added this to the Continuous Release milestone Oct 31, 2024

Maddosaurus mentioned this pull request Nov 4, 2024

ROX-24197: [rhacs-docs-4.6] Update docs for RHCOS scanning with Scanner V4 #84256

Merged

1 task

kcarmichael08 force-pushed the rox-26400-scanner-vex branch 2 times, most recently from 5333603 to 090255e Compare November 13, 2024 16:45

RTann reviewed Nov 15, 2024

View reviewed changes

kcarmichael08 force-pushed the rox-26400-scanner-vex branch from 090255e to ea48d08 Compare November 21, 2024 19:39

RTann reviewed Nov 25, 2024

View reviewed changes

modules/con-vuln-sources.adoc Outdated Show resolved Hide resolved

modules/consolidated-scanner.adoc Outdated Show resolved Hide resolved

modules/con-vuln-sources.adoc Outdated Show resolved Hide resolved

kcarmichael08 force-pushed the rox-26400-scanner-vex branch from ea48d08 to 8822c9d Compare November 26, 2024 13:47

kcarmichael08 added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 26, 2024

openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 26, 2024

kowen-rh reviewed Nov 26, 2024

View reviewed changes

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 26, 2024

kcarmichael08 force-pushed the rox-26400-scanner-vex branch from 8822c9d to 07ee993 Compare November 26, 2024 22:27

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024

kcarmichael08 force-pushed the rox-26400-scanner-vex branch from 07ee993 to 26c1c60 Compare November 26, 2024 22:54

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024

RTann approved these changes Nov 26, 2024

View reviewed changes

Update RHACS to use VEX

2e94237

kcarmichael08 force-pushed the rox-26400-scanner-vex branch from 26c1c60 to 2e94237 Compare November 26, 2024 23:08

kcarmichael08 merged commit d3957cd into openshift:rhacs-docs-main Nov 26, 2024
2 checks passed

kcarmichael08 deleted the rox-26400-scanner-vex branch November 26, 2024 23:25

openshift-cherrypick-robot mentioned this pull request Nov 26, 2024

[rhacs-docs-4.6] ROX:26400: Update RHACS to use VEX #85532

Merged

	The {product-title-short} Scanner V4 uses the OSV database available at link:https://osv.dev/[OSV.dev] under the link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache license].
	The {product-title-short} Scanner V4 uses the OSV database available at link:https://osv.dev/[OSV.dev] under link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache License 2.0].

	{product-title-short} uses the OSV database available at link:https://osv.dev/[OSV.dev] under the link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache license].
	{product-title-short} uses the OSV database available at link:https://osv.dev/[OSV.dev] under link:https://github.com/google/osv.dev/blob/master/LICENSE[Apache License 2.0].

ROX:26400: Update RHACS to use VEX #83406

ROX:26400: Update RHACS to use VEX #83406

Uh oh!

Conversation

kcarmichael08 commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 11, 2024

Uh oh!

RTann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RTann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kowen-rh commented Nov 26, 2024

Uh oh!

kowen-rh left a comment

Choose a reason for hiding this comment

Uh oh!

kowen-rh Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

RTann Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

RTann Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

RTann commented Nov 26, 2024

Uh oh!

kcarmichael08 commented Nov 26, 2024

Uh oh!

openshift-ci bot commented Nov 26, 2024

Uh oh!

kcarmichael08 commented Oct 11, 2024 •

edited

Loading

openshift-ci-robot commented Oct 11, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 11, 2024 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Oct 11, 2024 •

edited

Loading

openshift-ci-robot commented Oct 11, 2024 •

edited by openshift-ci bot

Loading