Skip to content

Conversation

@sean-freeman
Copy link
Contributor

@sean-freeman sean-freeman commented Oct 11, 2024

Create sub-directory for IPI under IBM Cloud infrastructure platform vendor-specific documentation. This includes re-writing of all filename references within the repository and fixes to chapter titles/introductions to follow sentence format used elsewhere (i.e. AWS, AZ).

Output structure after subdir creation

  • Installing on IBM Cloud
    • Installer-provisioned infrastructure
      • Installing a cluster with customizations on IBM Cloud
      • Installing a cluster with network customizations on IBM Cloud
      • Installing a cluster with an existing VPC network on IBM Cloud
      • Installing a private cluster with an existing VPC network on IBM Cloud
      • Installing a cluster with a restricted VPC network on IBM Cloud

Version(s):
4.17, do not cherry pick as this file is likely to have changed between each version

Issue:

  • None (GH or Jira), this is community author contribution

QE review:

  • QE has approved this change.

Additional information:

  • n/a

@sean-freeman
Copy link
Contributor Author

@kalexand-rh @bscott-rh @sheriff-rh Mentioning you all, as GH Issue template requests @openshift/team-documentation [which does not work] is mentioned after PR is raised.

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2024

Hi @sean-freeman. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sean-freeman
Copy link
Contributor Author

@kalexand-rh @bscott-rh @sheriff-rh Can you please review this PR? I would prefer to avoid merge conflicts which is more likely the longer this PR is open.

@bscott-rh
Copy link
Contributor

I am holding this PR until I can discuss with the docs program manager. This PR has the potential to affect the publishing system for the new docs site due to the topic map changes.

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2024
@ocpdocs-previewbot
Copy link

🤖 Thu Oct 24 20:04:05 - Prow CI generated the docs preview:
https://83420--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2024

@sean-freeman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal 71cb400 link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sean-freeman
Copy link
Contributor Author

@bscott-rh If changes are made to GCP structure (as described in another PR) in the new docs site, I would request this PR to be accepted also. Otherwise this conflicts with vendor neutrality

@bscott-rh
Copy link
Contributor

@sean-freeman after discussing with @kalexand-rh we are rejecting this PR. Aside from the additional work it generates on the customer portal, the change is not justified because there is no corresponding UPI installation process. Therefore this is simply adding an extra layer of directories, complicating the left hand TOC.

@bscott-rh bscott-rh closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants