-
Notifications
You must be signed in to change notification settings - Fork 1.8k
structure: subdir ibmcloud ipi #83420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
structure: subdir ibmcloud ipi #83420
Conversation
|
@kalexand-rh @bscott-rh @sheriff-rh Mentioning you all, as GH Issue template requests @openshift/team-documentation [which does not work] is mentioned after PR is raised. |
|
Hi @sean-freeman. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kalexand-rh @bscott-rh @sheriff-rh Can you please review this PR? I would prefer to avoid merge conflicts which is more likely the longer this PR is open. |
|
I am holding this PR until I can discuss with the docs program manager. This PR has the potential to affect the publishing system for the new docs site due to the topic map changes. /ok-to-test |
|
🤖 Thu Oct 24 20:04:05 - Prow CI generated the docs preview: |
installing/installing_ibm_cloud/ipi/installing-ibm-cloud-restricted.adoc
Show resolved
Hide resolved
|
@sean-freeman: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@bscott-rh If changes are made to GCP structure (as described in another PR) in the new docs site, I would request this PR to be accepted also. Otherwise this conflicts with vendor neutrality |
|
@sean-freeman after discussing with @kalexand-rh we are rejecting this PR. Aside from the additional work it generates on the customer portal, the change is not justified because there is no corresponding UPI installation process. Therefore this is simply adding an extra layer of directories, complicating the left hand TOC. |
Create sub-directory for IPI under IBM Cloud infrastructure platform vendor-specific documentation. This includes re-writing of all filename references within the repository and fixes to chapter titles/introductions to follow sentence format used elsewhere (i.e. AWS, AZ).
Version(s):
4.17, do not cherry pick as this file is likely to have changed between each version
Issue:
QE review:
Additional information: