Skip to content

Conversation

HarshadaPatil25
Copy link
Contributor

@HarshadaPatil25 HarshadaPatil25 commented Oct 16, 2024

NO QE NEEDED. CONFIRMED WITH DPM.

Jira:
https://issues.redhat.com/browse/OCPBUGS-41344

Version(s):
OpenShift Version: 4.15

Issue:
Updated the RHEL8 versions for worker nodes in release notes for RHOCP4.15

Link to docs preview:
About this release

  • SME has approved this change (Scott Dodson).

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2024
Copy link

openshift-ci bot commented Oct 16, 2024

Hi @HarshadaPatil25. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dfitzmau dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.15 labels Oct 17, 2024
@dfitzmau
Copy link
Contributor

/retest

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 17, 2024

🤖 Thu Jan 02 10:24:43 - Prow CI generated the docs preview:

https://83662--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes.html

@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented Dec 2, 2024

/retest

@sdodson
Copy link
Member

sdodson commented Dec 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@dfitzmau dfitzmau added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 19, 2024
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 19, 2024
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo here that has to be fixed before we can merge. Can you please fix it, and then be sure to squash your commits?

And then once you do that, you can add it back to the merge review queue by commenting /label merge-review-needed. (I'm out after today until the new year, otherwise I would say that you can just ping me). Thanks!

@bergerhoffer bergerhoffer removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Dec 19, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
Copy link

openshift-ci bot commented Dec 23, 2024

New changes are detected. LGTM label has been removed.

Signed-off-by: Harshada Patil <harshadasanjaypatil25@gmail.com>

Update release_notes/ocp-4-15-release-notes.adoc

Co-authored-by: Darragh Fitzmaurice <57954076+dfitzmau@users.noreply.github.com>

Update ocp-4-15-release-notes.adoc

Update release_notes/ocp-4-15-release-notes.adoc

Co-authored-by: Andrea Hoffer <bergerhoffer@users.noreply.github.com>
@dfitzmau
Copy link
Contributor

dfitzmau commented Jan 2, 2025

/retest

Copy link

openshift-ci bot commented Jan 2, 2025

@HarshadaPatil25: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 2, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 2, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM

@xenolinux xenolinux merged commit e6c50e8 into openshift:enterprise-4.15 Jan 2, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants