Skip to content

"Redeploying Master Certificates Only" recreates "Service Serving Certificates" CA Certificate #8373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2018
Merged

"Redeploying Master Certificates Only" recreates "Service Serving Certificates" CA Certificate #8373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion install_config/redeploying_certificates.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,17 @@ file:

----
$ ansible-playbook -i <inventory_file> \
/usr/share/ansible/openshift-ansible/playbooks/openshift-master/redeploy-certificates.yml
/usr/share/ansible/openshift-ansible/playbooks/openshift-master/redeploy-master-certificates.yml
Copy link

@gpei gpei Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The playbook name should not be changed. The previous one is correct for ocp-3.9.
What we may need to improve is "redeploy-master-certificates.yml playbook" in line380, for more specifically, we should name it as "master redeploy-certificates.yml playbook".
So is in line 402 and line 421, which should be:
The etcd redeploy-certificates.yml playbook
The node redeploy-certificates.yml playbook

----

[IMPORTANT]
Copy link

@gpei gpei Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part lgtm 👍

====
After running this playbook, you need to regenerate any xref:../dev_guide/secrets.adoc#service-serving-certificate-secrets[service signing certificate or key pairs]
by deleting existing secrets that contain service serving certificates or removing and re-adding
annotations to appropriate services.
====


[[redeploying-etcd-certificates]]
=== Redeploying etcd Certificates Only

Expand Down