Skip to content

Conversation

@agantony
Copy link
Contributor

@agantony agantony commented Oct 18, 2024

Version(s):
4.6+

Issue:
https://issues.redhat.com/browse/ROX-25681

Link to docs preview:
https://83766--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrating-with-microsoft-sentinel-notifier#improving-threat-detection_integrate-with-splunk

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.6

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2024

@agantony: This pull request references ROX-25681 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue:
https://issues.redhat.com/browse/ROX-25681

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony
Copy link
Contributor Author

/label RHACS

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. RHACS Label for RHACS related PRs that go in the rhacs-docs branch labels Oct 18, 2024
@agantony agantony force-pushed the ROX25681-rhacs-docs-main branch from 06eff9d to 3d6eb23 Compare October 18, 2024 13:44
@agantony
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 18, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 18, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2024

@agantony: This pull request references ROX-25681 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue:
https://issues.redhat.com/browse/ROX-25681

Link to docs preview:
https://83766--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrating-with-microsoft-sentinel-notifier#improving-threat-detection_integrate-with-splunk

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony
Copy link
Contributor Author

/assign @SimonBaeumer

@jneczypor
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 18, 2024
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 18, 2024
@agantony agantony force-pushed the ROX25681-rhacs-docs-main branch from a25516b to 41a5f51 Compare October 20, 2024 07:30
@SimonBaeumer
Copy link

I think we had a miscommunication here, the doc should describe how to setup the Sentinel integration. Here are missing all the essential parts. We will continue the discussion in Slack.

@agantony agantony force-pushed the ROX25681-rhacs-docs-main branch from 41a5f51 to e2bfecb Compare October 25, 2024 15:10
@agantony agantony changed the title [RHACS][Docs][4.6 and later versions] ROX-25681: Adding Microsoft Sentinel notifier documentation [RHACS][Docs][4.6 and later versions] ROX-25681: Adding Microsoft Sentinel notifier documentat Oct 25, 2024
@agantony agantony changed the title [RHACS][Docs][4.6 and later versions] ROX-25681: Adding Microsoft Sentinel notifier documentat [RHACS][Docs][4.6 and later versions] ROX-25681: Adding Microsoft Sentinel notifier documentation Oct 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2024

@agantony: This pull request references ROX-25681 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue:
https://issues.redhat.com/browse/ROX-25681

Link to docs preview:
https://83766--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrating-with-microsoft-sentinel-notifier#improving-threat-detection_integrate-with-splunk

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2024

@agantony: This pull request references ROX-25681 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue:
https://issues.redhat.com/browse/ROX-25681

Link to docs preview:
https://83766--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrating-with-microsoft-sentinel-notifier#improving-threat-detection_integrate-with-splunk

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony closed this Oct 29, 2024
@agantony agantony reopened this Oct 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2024

@agantony: This pull request references ROX-25681 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue:
https://issues.redhat.com/browse/ROX-25681

Link to docs preview:
https://83766--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrating-with-microsoft-sentinel-notifier#improving-threat-detection_integrate-with-splunk

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony changed the title [RHACS][Docs][4.6 and later versions] ROX-25681: Adding Microsoft Sentinel notifier documentation [RHACS][Docs][4.6 and later versions] ROX-25681: Adding Microsoft Sentinel integration documentation Oct 29, 2024
Copy link

@SimonBaeumer SimonBaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agantony The doc looks good, overall some smaller changes related to Azure's structure and wording. Thanks for putting this together.

@agantony agantony force-pushed the ROX25681-rhacs-docs-main branch 3 times, most recently from 836a366 to 9047bc9 Compare November 5, 2024 12:33
ROX25681 Extra space

ROX25681 Updating context

ROX25681 Some improvements

ROX25681 Some improvements

ROX25681 Some improvements

ROX25681 Small improvement

ROX25681 Small improvements

ROX25681 Small improvements

ROX25681 SME feedback

ROX25681 SME feedback

ROX25681 SME feedback

ROX25681 SME feedback

ROX25681 SME feedback
@agantony agantony force-pushed the ROX25681-rhacs-docs-main branch from d23ed8f to 78a090c Compare November 6, 2024 05:40
@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2024

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SimonBaeumer
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

@agantony: This pull request references ROX-25681 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue:
https://issues.redhat.com/browse/ROX-25681

Link to docs preview:
https://83766--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrating-with-microsoft-sentinel-notifier#improving-threat-detection_integrate-with-splunk

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherry-pick to:
    • rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony merged commit 11972a7 into openshift:rhacs-docs-main Nov 7, 2024
2 checks passed
@agantony
Copy link
Contributor Author

agantony commented Nov 7, 2024

/cherrypick rhacs-docs-4.6

@openshift-cherrypick-robot

@agantony: new pull request created: #84579

In response to this:

/cherrypick rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants