-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[RHACS][Docs][4.6 and later versions] ROX-25681: Adding Microsoft Sentinel integration documentation #83766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHACS][Docs][4.6 and later versions] ROX-25681: Adding Microsoft Sentinel integration documentation #83766
Conversation
|
@agantony: This pull request references ROX-25681 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label RHACS |
06eff9d to
3d6eb23
Compare
|
/label peer-review-needed |
|
🤖 Wed Nov 06 05:52:37 - Prow CI generated the docs preview: |
|
@agantony: This pull request references ROX-25681 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @SimonBaeumer |
|
/label peer-review-in-progress |
jneczypor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
a25516b to
41a5f51
Compare
|
I think we had a miscommunication here, the doc should describe how to setup the Sentinel integration. Here are missing all the essential parts. We will continue the discussion in Slack. |
41a5f51 to
e2bfecb
Compare
|
@agantony: This pull request references ROX-25681 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@agantony: This pull request references ROX-25681 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@agantony: This pull request references ROX-25681 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
SimonBaeumer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agantony The doc looks good, overall some smaller changes related to Azure's structure and wording. Thanks for putting this together.
836a366 to
9047bc9
Compare
ROX25681 Extra space ROX25681 Updating context ROX25681 Some improvements ROX25681 Some improvements ROX25681 Some improvements ROX25681 Small improvement ROX25681 Small improvements ROX25681 Small improvements ROX25681 SME feedback ROX25681 SME feedback ROX25681 SME feedback ROX25681 SME feedback ROX25681 SME feedback
d23ed8f to
78a090c
Compare
|
@agantony: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@agantony: This pull request references ROX-25681 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick rhacs-docs-4.6 |
|
@agantony: new pull request created: #84579 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.6+
Issue:
https://issues.redhat.com/browse/ROX-25681
Link to docs preview:
https://83766--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrating-with-microsoft-sentinel-notifier#improving-threat-detection_integrate-with-splunk
SME review:
Additional information:
rhacs-docs-mainand cherry-pick to:rhacs-docs-4.6