Skip to content

Conversation

@gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Oct 21, 2024

Restructure

PR re-opened to be used for restructuring metrics, traces, and Kiali into "Observability."

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main

Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0.0tp1

OSSM-8257 Kiali Concept Content https://issues.redhat.com/browse/OSSM-8257

This PR is part of the standalone doc set for the OpenShift Service Mesh project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

Version(s): Technology Preview

Service Mesh 3.0 is moving to the stand alone format and will not be cherry-picked back to OCP core branches.

Issue:
https://issues.redhat.com/browse/OSSM-8257

Link to docs preview:

https://83871--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/observability/ossm-observability-service-mesh-assembly.html

QE review:
Restructuring of existing content. Existing content has not changed so this PR does not require QE approval.

Additional information:
The following content has been through peer review and merge review and has been live:

Metrics and Service Mesh
Tracing and Service Mesh
Kiali Operator provided by Red Hat

This PR does not change that content. This PR restructures that content under an "Observability" umbrella.

Note that this content is likely to change between now and GA. Some things were noticed while I was creating the Observability distro, and they have been noted in a separate Jira Epic for GA issues.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2024
@gwynnemonahan gwynnemonahan changed the title OSSM 3.0 TP1 OSSM-8257 Kiali Concept Content [WIP] OSSM 3.0 TP1 OSSM-8257 Kiali Concept Content Oct 22, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Oct 22, 2024

Closing PR as content is being handled by #83560

@gwynnemonahan gwynnemonahan reopened this Oct 22, 2024
@gwynnemonahan gwynnemonahan changed the title [WIP] OSSM 3.0 TP1 OSSM-8257 Kiali Concept Content [WIP] OSSM 3.0 TP1 OSSM-8257 Kiali Concept Content creating Observability, moving content accordingly Oct 22, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2024
@gwynnemonahan gwynnemonahan force-pushed the OSSM-8257 branch 2 times, most recently from a17b612 to fabe28c Compare October 23, 2024 20:48
Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a better topic name than "Metrics". I had originally meant "Observability" in a general sense of the term, but tying it specifically to OpenShift Observability is fine, maybe better.

@gwynnemonahan gwynnemonahan changed the title [WIP] OSSM 3.0 TP1 OSSM-8257 Kiali Concept Content creating Observability, moving content accordingly OSSM 3.0 TP1 OSSM-8257 Kiali Concept Content creating Observability, moving content accordingly Oct 29, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@gwynnemonahan gwynnemonahan force-pushed the OSSM-8257 branch 2 times, most recently from 098936c to 74adbb7 Compare October 29, 2024 14:49
Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 29, 2024
@dfitzmau
Copy link
Contributor

Hi @gwynnemonahan . Merge conflicts exist with this PR. Would you be OK to resolve them?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2024
@gwynnemonahan
Copy link
Contributor Author

Hey @dfitzmau ,

Oh, it needs to be rebased. Ha. OK. I just rebased, so hopefully that'll fix it.

@dfitzmau dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 30, 2024
@dfitzmau dfitzmau added the service-mesh Label for all Service Mesh PRs label Oct 30, 2024
@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 30, 2024
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 30, 2024
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 30, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2024

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 30, 2024
@mburke5678 mburke5678 merged commit 1e6bd8c into openshift:service-mesh-docs-main Oct 30, 2024
2 checks passed
@mburke5678
Copy link
Contributor

/cherrypick service-mesh-docs-3.0.0tp1

@openshift-cherrypick-robot

@mburke5678: new pull request created: #84269

In response to this:

/cherrypick service-mesh-docs-3.0.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants