Skip to content

CNV-49892: 4.14-specific changes to NetworkAttachmentDefinition YAML #83885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

CNV-49892: 4.14-specific changes to NetworkAttachmentDefinition YAML #83885

merged 1 commit into from
Oct 29, 2024

Conversation

@sjhala-ccs
Copy link
Contributor

@sjhala-ccs sjhala-ccs commented Oct 21, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 21, 2024 •
edited by openshift-ci bot
Loading

@sjhala-ccs: This pull request references CNV-49892 which is a valid jira issue.

In response to this:

Version(s): 4.14

Issue: CNV-49892

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2024
@sjhala-ccs sjhala-ccs added CNV Label for all CNV PRs branch/enterprise-4.14 labels Oct 21, 2024
@sjhala-ccs sjhala-ccs added this to the Continuous Release milestone Oct 21, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 21, 2024 •
edited
Loading

🤖 Wed Oct 23 20:00:05 - Prow CI generated the docs preview:

https://83885--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/advanced_vm_management/virt-configuring-pxe-booting.html
https://83885--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-linux-bridge.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 21, 2024 •
edited by openshift-ci bot
Loading

@sjhala-ccs: This pull request references CNV-49892 which is a valid jira issue.

In response to this:

Version(s): 4.14

Issue: CNV-49892

Link to docs preview: https://83885--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-linux-bridge.html#virt-creating-linux-bridge-nad-cli_virt-connecting-vm-to-linux-bridge

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2024

@sjhala-ccs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yossisegev
yossisegev approved these changes Oct 29, 2024
View reviewed changes
Copy link

@yossisegev yossisegev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by CNV network QE.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2024 •
edited by openshift-ci bot
Loading

@sjhala-ccs: This pull request references CNV-49892 which is a valid jira issue.

In response to this:

Version(s): 4.14

Issue: CNV-49892

Link to docs preview: https://83885--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-linux-bridge.html#virt-creating-linux-bridge-nad-cli_virt-connecting-vm-to-linux-bridge

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjhala-ccs
Copy link
Contributor Author

sjhala-ccs commented Oct 29, 2024

Peer review was completed on #83835

@sjhala-ccs sjhala-ccs merged commit ef5284a into openshift:enterprise-4.14 Oct 29, 2024
2 checks passed
@sjhala-ccs sjhala-ccs deleted the cnv-49892-4-14 branch October 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yossisegev yossisegev yossisegev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.14 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

4 participants

@sjhala-ccs @openshift-ci-robot @ocpdocs-previewbot @yossisegev