Skip to content

Conversation

@sean-freeman
Copy link
Contributor

Address comment #83386 (comment) and resolve missed readability changes (made in 4.16) for IPI/UPI suffix on assembly titles.

Version(s):
4.17, do not cherry pick as this file is likely to have changed between each version

Issue:

  • None (GH or Jira), this is community author contribution

QE review:

  • QE has approved this change.

Additional information:

  • n/a

@sean-freeman
Copy link
Contributor Author

@kalexand-rh @bscott-rh @sheriff-rh Mentioning you all, as GH Issue template requests @openshift/team-documentation [which does not work] is mentioned after PR is raised.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2024

Hi @sean-freeman. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sean-freeman
Copy link
Contributor Author

@bscott-rh Based on previous comments, this should be ready for testing and merge

@bscott-rh
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2024
@ocpdocs-previewbot
Copy link

🤖 Tue Nov 05 20:21:07 - Prow CI generated the docs preview:
https://84115--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2024

@sean-freeman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bscott-rh bscott-rh added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.17 branch/enterprise-4.18 labels Nov 5, 2024
@bscott-rh bscott-rh added this to the Continuous Release milestone Nov 5, 2024
@bscott-rh bscott-rh removed the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 5, 2024
@bscott-rh
Copy link
Contributor

After reviewing with @sstout-rh, I am closing this PR in favor of keeping the original wording.

@bscott-rh bscott-rh closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 branch/enterprise-4.18 ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants