Skip to content

Conversation

@jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Oct 25, 2024

Version(s):
TBD

Issue:
OSDOCS-12375

Link to docs preview:
TOC, many topics in the Machine management book, and locations linked to from that book

QE review:
No changes to existing content at this stage

Additional information:
Reviewers: please reach out directly with questions, I am happy to chat about this.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2024

@jeana-redhat: This pull request references OSDOCS-12375 which is a valid jira issue.

In response to this:

Version(s):
TBD

Issue:
OSDOCS-12375

Link to docs preview:
🚧 this will take some work to get a build

QE review:

  • QE has approved this change.

Additional information:
The most in-progress WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 25, 2024
@jeana-redhat jeana-redhat force-pushed the OSDOCS-12375-new-dir-structure branch from 14c2d0f to 8a9fb0f Compare October 25, 2024 14:06
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2024
@jeana-redhat jeana-redhat force-pushed the OSDOCS-12375-new-dir-structure branch 5 times, most recently from 861e7aa to acddf48 Compare October 25, 2024 14:59
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 25, 2024

🤖 Tue Oct 29 14:29:41 - Prow CI generated the docs preview:
https://84127--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@jeana-redhat jeana-redhat force-pushed the OSDOCS-12375-new-dir-structure branch 4 times, most recently from e3bbcfc to e238272 Compare October 25, 2024 18:11
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2024
jeana-redhat

This comment was marked as outdated.

@jeana-redhat jeana-redhat force-pushed the OSDOCS-12375-new-dir-structure branch from 04b4787 to 093057d Compare October 25, 2024 18:56
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 25, 2024
Comment on lines 2319 to 2354
# - Name: About compute machine sets
# File: mapi-compute-about
# - Name: Getting started with compute machine sets
# File: mapi-compute-getting-started
- Name: Managing compute machines with compute machine sets
Dir: mapi_compute_managing_machines
Topics:
- Name: Manually scaling a compute machine set
File: manually-scaling-machineset
- Name: Modifying a compute machine set
File: modifying-machineset
# - Name: Compute machine set configuration
# File: mapi-compute-configuration
# - Name: Configuration options for compute machines
# Dir: mapi_compute_provider_configurations
# Topics:
# - Name: Compute configuration options for Amazon Web Services
# File: mapi-compute-config-options-aws
# - Name: Compute configuration options for Microsoft Azure
# File: mapi-compute-config-options-azure
# - Name: Compute configuration options for Google Cloud Platform
# File: mapi-compute-config-options-gcp
# - Name: Compute configuration options for Nutanix
# File: mapi-compute-config-options-nutanix
# - Name: Compute configuration options for Red Hat OpenStack Platform
# File: mapi-compute-config-options-openstack
# - Name: Compute configuration options for VMware vSphere
# File: mapi-compute-config-options-vsphere
- Name: Applying autoscaling to a cluster
File: applying-autoscaling
# - Name: Compute resiliency and recovery
# File: mapi-compute-resiliency
# - Name: Troubleshooting the compute machine set
# File: mapi-compute-troubleshooting
# - Name: Disabling compute machine sets
# File: mapi-compute-disabling
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out assemblies and directories will be uncommented and added in a later stage

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2024
@jeana-redhat jeana-redhat force-pushed the OSDOCS-12375-new-dir-structure branch from c4a9199 to 34b4c2c Compare October 25, 2024 20:41
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2024

@jeana-redhat: This pull request references OSDOCS-12375 which is a valid jira issue.

In response to this:

Version(s):
TBD

Issue:
OSDOCS-12375

Link to docs preview:
🚧 this will take some work to get a build

QE review:
No changes to existing content at this stage

Additional information:
The most in-progress WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2024

@jeana-redhat: This pull request references OSDOCS-12375 which is a valid jira issue.

In response to this:

Version(s):
TBD

Issue:
OSDOCS-12375

Link to docs preview:
🚧

QE review:
No changes to existing content at this stage

Additional information:
Reviewers: please reach out directly with questions, I am happy to chat about this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2024

@jeana-redhat: This pull request references OSDOCS-12375 which is a valid jira issue.

In response to this:

Version(s):
TBD

Issue:
OSDOCS-12375

Link to docs preview:
TOC, many topics in the Machine management book, and locations linked to from that book

QE review:
No changes to existing content at this stage

Additional information:
Reviewers: please reach out directly with questions, I am happy to chat about this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeana-redhat jeana-redhat added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 25, 2024
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 28, 2024
= Adding compute machines to clusters with user-provisioned infrastructure manually
include::_attributes/common-attributes.adoc[]
:context: adding-compute-user-infra-general

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assembly is subsequently overwhelming and underwhelming!
The heading after heading after heading seems like a bit much visually, to me. And then, each module is only a link is a bit disappointing.
I wonder if there is another way to present this. Or not. Up to you. Matter of opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sprucing this assembly up is part of the plan. For now it has moved as-is, but your feedback is right on the money in terms of what I think it needs 🥂

@mburke5678
Copy link
Contributor

/lgtm save for one comment.

@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 28, 2024
@jeana-redhat jeana-redhat removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Oct 29, 2024
@jeana-redhat jeana-redhat force-pushed the OSDOCS-12375-new-dir-structure branch from 0b8920a to 2cedfe2 Compare October 29, 2024 14:18
@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2024

@jeana-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jeana-redhat jeana-redhat merged commit 769b701 into openshift:ocp-docs-cluster_infra_reorg Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants