-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-12375: Replace directory structure #84127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-12375: Replace directory structure #84127
Conversation
|
@jeana-redhat: This pull request references OSDOCS-12375 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
14c2d0f to
8a9fb0f
Compare
861e7aa to
acddf48
Compare
|
🤖 Tue Oct 29 14:29:41 - Prow CI generated the docs preview: |
e3bbcfc to
e238272
Compare
04b4787 to
093057d
Compare
| # - Name: About compute machine sets | ||
| # File: mapi-compute-about | ||
| # - Name: Getting started with compute machine sets | ||
| # File: mapi-compute-getting-started | ||
| - Name: Managing compute machines with compute machine sets | ||
| Dir: mapi_compute_managing_machines | ||
| Topics: | ||
| - Name: Manually scaling a compute machine set | ||
| File: manually-scaling-machineset | ||
| - Name: Modifying a compute machine set | ||
| File: modifying-machineset | ||
| # - Name: Compute machine set configuration | ||
| # File: mapi-compute-configuration | ||
| # - Name: Configuration options for compute machines | ||
| # Dir: mapi_compute_provider_configurations | ||
| # Topics: | ||
| # - Name: Compute configuration options for Amazon Web Services | ||
| # File: mapi-compute-config-options-aws | ||
| # - Name: Compute configuration options for Microsoft Azure | ||
| # File: mapi-compute-config-options-azure | ||
| # - Name: Compute configuration options for Google Cloud Platform | ||
| # File: mapi-compute-config-options-gcp | ||
| # - Name: Compute configuration options for Nutanix | ||
| # File: mapi-compute-config-options-nutanix | ||
| # - Name: Compute configuration options for Red Hat OpenStack Platform | ||
| # File: mapi-compute-config-options-openstack | ||
| # - Name: Compute configuration options for VMware vSphere | ||
| # File: mapi-compute-config-options-vsphere | ||
| - Name: Applying autoscaling to a cluster | ||
| File: applying-autoscaling | ||
| # - Name: Compute resiliency and recovery | ||
| # File: mapi-compute-resiliency | ||
| # - Name: Troubleshooting the compute machine set | ||
| # File: mapi-compute-troubleshooting | ||
| # - Name: Disabling compute machine sets | ||
| # File: mapi-compute-disabling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented out assemblies and directories will be uncommented and added in a later stage
c4a9199 to
34b4c2c
Compare
|
@jeana-redhat: This pull request references OSDOCS-12375 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jeana-redhat: This pull request references OSDOCS-12375 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
machine_management/creating_machinesets/creating-infrastructure-machinesets.adoc
Show resolved
Hide resolved
|
@jeana-redhat: This pull request references OSDOCS-12375 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| = Adding compute machines to clusters with user-provisioned infrastructure manually | ||
| include::_attributes/common-attributes.adoc[] | ||
| :context: adding-compute-user-infra-general | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assembly is subsequently overwhelming and underwhelming!
The heading after heading after heading seems like a bit much visually, to me. And then, each module is only a link is a bit disappointing.
I wonder if there is another way to present this. Or not. Up to you. Matter of opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sprucing this assembly up is part of the plan. For now it has moved as-is, but your feedback is right on the money in terms of what I think it needs 🥂
|
/lgtm save for one comment. |
0b8920a to
2cedfe2
Compare
|
@jeana-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
769b701
into
openshift:ocp-docs-cluster_infra_reorg
Version(s):
TBD
Issue:
OSDOCS-12375
Link to docs preview:
TOC, many topics in the Machine management book, and locations linked to from that book
QE review:
No changes to existing content at this stage
Additional information:
Reviewers: please reach out directly with questions, I am happy to chat about this.