-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1472: Prepare Enabling monitoring for user-defined projects f… #84580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-1472: Prepare Enabling monitoring for user-defined projects f… #84580
Conversation
@eromanova97: This pull request references OBSDOCS-1472 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
21250c6
to
719ffde
Compare
🤖 Thu Nov 07 08:54:43 - Prow CI generated the docs preview: https://84580--ocpdocs-pr.netlify.app/ |
@eromanova97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@eromanova97: This pull request references OBSDOCS-1472 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
https://84580--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/enabling-monitoring-for-user-defined-projects.html found it's the same for 4.17 released doc: https://docs.openshift.com/container-platform/4.17/observability/monitoring/enabling-monitoring-for-user-defined-projects.html |
@juzhao Oh yes, I actually don't like it either. The problem here is that the first one is the name of the whole file while the second one is the name of the actual procedure involved. Both titles must be there due to our doc rules and the way they are structured. So the only thing that can be done here is to rename them. The procedure being called "Enabling monitoring for user-defined projects" makes sense. However, the whole chapter being called the same makes sense as well. It is not wrong to have it as it is currently, but if you have any ideas, let me know |
keep it is fine, maybe others have an idea for it. |
/label peer-review-needed |
@eromanova97: This pull request references OBSDOCS-1472 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. @eromanova97 Can you confirm the merge target for this?
Hello @maxwelldb it only goes to the branch against which it is raised ( |
24da361
into
openshift:monitoring-docs-restructure
Version(s) for cherry-picking: none
Issue: OBSDOCS-1472
Link to docs preview: no preview necessary
QE review:
Additional information: