Skip to content

OSDOCS#45783: Added a Release Note on CentOS 7+8 support removal #84704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

OSDOCS#45783: Added a Release Note on CentOS 7+8 support removal #84704

merged 1 commit into from
Nov 19, 2024

Conversation

@jherrman
Copy link
Contributor

@jherrman jherrman commented Nov 9, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 9, 2024 •
edited by openshift-ci bot
Loading

@jherrman: This pull request references CNV-45783 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/CNV-45783

Link to docs preview:
TBA

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2024
@jherrman jherrman changed the title CNV-45783: Added a Release Note on CentOS 7+8 support removal OSDOCS#45783: Added a Release Note on CentOS 7+8 support removal Nov 9, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 9, 2024

@jherrman: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/CNV-45783

Link to docs preview:
TBA

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jherrman jherrman mentioned this pull request Nov 9, 2024
Merged
1 task
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 9, 2024 •
edited
Loading

🤖 Tue Nov 19 13:14:47 - Prow CI generated the docs preview:

https://84704--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html

This was referenced Nov 9, 2024
Merged
Merged
@RoniKishner
Copy link

RoniKishner commented Nov 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@jherrman
Copy link
Contributor Author

jherrman commented Nov 18, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 18, 2024
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 18, 2024
skopacz1
skopacz1 reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise LGTM

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.14 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 18, 2024
@skopacz1 skopacz1 added this to the Continuous Release milestone Nov 18, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2024

New changes are detected. LGTM label has been removed.

@jherrman @skopacz1
CNV-45783: Added a Release Note on CentOS 7+8 support removal
ea74133 
Applied peer review

Kudos to skopacz1

Co-authored-by: Sebastian Kopacz <112414607+skopacz1@users.noreply.github.com>
@jherrman
Copy link
Contributor Author

jherrman commented Nov 19, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 19, 2024
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2024

@jherrman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit removed the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 19, 2024
@stevsmit stevsmit added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 19, 2024
@stevsmit
Copy link
Member

stevsmit commented Nov 19, 2024

lgtm

@stevsmit stevsmit merged commit 1ce1c44 into openshift:enterprise-4.14 Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skopacz1 skopacz1 skopacz1 left review comments

Assignees

@RoniKishner RoniKishner

Labels

branch/enterprise-4.14 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@jherrman @openshift-ci-robot @ocpdocs-previewbot @RoniKishner @stevsmit @skopacz1