Skip to content

Conversation

@mburke5678
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2018
@mburke5678 mburke5678 added this to the Next Release milestone Apr 4, 2018
@mburke5678
Copy link
Contributor Author

@jianlinliu PTAL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you likely want to have this command read:

# cat intermediate/certs/intermediate.cert.pem \
      certs/ca.cert.pem >> intermediate/certs/ca-chain.cert.pem

Using >> so that you append to the file, and not overwrite the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be included in a PR about CA certificates?

@mburke5678
Copy link
Contributor Author

@openshift/team-documentation PTAL

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the closing code block above, ---- , but should there be an opening? Above line 337?

@mburke5678 mburke5678 merged commit b0c024b into openshift:master Apr 12, 2018
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.7

@openshift-cherrypick-robot

@mburke5678: new pull request created: #8723

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.9

@openshift-cherrypick-robot

@mburke5678: new pull request created: #8724

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.10

@openshift-cherrypick-robot

@mburke5678: new pull request created: #8725

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants