Skip to content

Conversation

@rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Dec 11, 2024

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue:
https://issues.redhat.com/browse/OSSM-6856

Link to docs preview:
https://86115--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html#ossm-about-service-mesh-custom-resource-definitions_ossm-installing-operator

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024

@rh-tokeefe: This pull request references OSSM-6856 which is a valid jira issue.

In response to this:

Version(s):

Issue:
https://issues.redhat.com/browse/OSSM-6856

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 11, 2024

🤖 Thu Dec 19 22:09:32 - Prow CI generated the docs preview:
https://86115--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@rh-tokeefe
Copy link
Contributor Author

/restest

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@rh-tokeefe rh-tokeefe force-pushed the OSSM-6856 branch 2 times, most recently from ab14788 to e710b37 Compare December 11, 2024 22:21
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024

@rh-tokeefe: This pull request references OSSM-6856 which is a valid jira issue.

In response to this:

Version(s):

Issue:
https://issues.redhat.com/browse/OSSM-6856

Link to docs preview:
https://86115--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html#ossm-about-service-mesh-custom-resource-definitions_ossm-installing-operator

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024

@rh-tokeefe: This pull request references OSSM-6856 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue:
https://issues.redhat.com/browse/OSSM-6856

Link to docs preview:
https://86115--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html#ossm-about-service-mesh-custom-resource-definitions_ossm-installing-operator

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe
Copy link
Contributor Author

/retest

Copy link
Contributor

@luksa luksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkralik3
Copy link
Contributor

LGTM

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 17, 2024
@jeana-redhat jeana-redhat self-requested a review December 19, 2024 21:35
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor stuff here :)

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 19, 2024
@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2024

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 20, 2024

@rh-tokeefe: This pull request references OSSM-6856 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue:
https://issues.redhat.com/browse/OSSM-6856

Link to docs preview:
https://86115--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html#ossm-about-service-mesh-custom-resource-definitions_ossm-installing-operator

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skopacz1 skopacz1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR service-mesh Label for all Service Mesh PRs labels Dec 20, 2024
@skopacz1 skopacz1 added this to the Continuous Release milestone Dec 20, 2024
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM

@skopacz1 skopacz1 merged commit 9395edb into openshift:service-mesh-docs-main Dec 20, 2024
2 checks passed
@skopacz1
Copy link
Contributor

/cherrypick service-mesh-docs-3.0.0tp1

@openshift-cherrypick-robot

@skopacz1: new pull request created: #86536

In response to this:

/cherrypick service-mesh-docs-3.0.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants