(enterprise-4.13) Indentation fault in Configuring CPU and memory limits for logging components #86306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its for logging components - Indentation fault in Configuring CPU and memory limits for logging components in Documentation. - Here is the documentation link: https://docs.openshift.com/container-platform/4.13/observability/logging/config/cluster-logging-memory.html#cluster-logging-memory-limits_cluster-logging-memory - Here, `spec.collection` indentation is wrongly mentioned. ~~~ apiVersion: "logging.openshift.io/v1" kind: "ClusterLogging" metadata: name: "instance" namespace: openshift-logging spec: collection: <<== collection indentation is wrongly mentioned resources: limits: memory: 736Mi requests: cpu: 200m memory: 736Mi type: fluentd ~~~ - Due to this `spec.collection` will not get applied in the ClusterLogging instance CR. - The correct configuration should look like the following: ~~~ apiVersion: "logging.openshift.io/v1" kind: "ClusterLogging" metadata: name: "instance" namespace: openshift-logging spec: collection: <<== Here is the correct indentation resources: limits: memory: 736Mi requests: cpu: 200m memory: 736Mi type: fluentd ~~~
openshift-ci
bot
added
the
size/XS
|
@prithvipatil97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 task
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
snarayan-redhat
added
peer-review-in-progress
snarayan-redhat
added
peer-review-done
|
Hello @snarayan-redhat , |
|
Hello Team, @anpingli , @kabirbhartiRH , @QiaolingTang , It would be really helpful if someone could please take a look and provide QE approval for this change. Thanks in advance. |
|
LGTM. |
|
Hello @QiaolingTang , Regards, |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
stevsmit
added
merge-review-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indentation fault in Configuring CPU and memory limits for logging components in Documentation.
Here is the documentation link: https://docs.openshift.com/container-platform/4.13/observability/logging/config/cluster-logging-memory.html#cluster-logging-memory-limits_cluster-logging-memory
Here,
spec.collectionindentation is wrongly mentioned.spec.collectionwill not get applied in the ClusterLogging instance CR.Version(s):
RHOCP 4.13Issue:
https://issues.redhat.com/browse/OBSDOCS-1522Link to docs preview:
https://86306--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/config/cluster-logging-memory.html
https://86306--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/log_visualization/logging-kibana.html
QE review:
Additional information: