Skip to content

Conversation

xenolinux
Copy link
Contributor

@xenolinux xenolinux commented Jan 12, 2025

Context: dev's review comment:

The multiArch flag is deprecated in 4.18 but it is not deprecated in 4.17. Therefore, this change[1] is not required in 4.18 but is required in 4.17. After merging the main PR in 4.17 and 4.18, (with the removed step[1]) opening a follow-up PR just to add the step[1] in enterprise-4.17.

[1] https://github.com/openshift/openshift-docs/pull/86931/files#diff-862ebee6ae4811edf5e6835d73dc5025b1b921e24fe3bb6711eb625b8ea7cc6eR85-R97

Version(s): 4.17

Issue: https://issues.redhat.com/browse/OSDOCS-12034

Link to docs preview: Preview

QE, SME, and peer reviews:

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 12, 2025
@ocpdocs-previewbot
Copy link

🤖 Sun Jan 12 06:44:38 - Prow CI generated the docs preview:

https://86931--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-manage/hcp-manage-aws.html

Copy link

openshift-ci bot commented Jan 12, 2025

@xenolinux: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux merged commit 2c468d7 into openshift:enterprise-4.17 Jan 12, 2025
2 checks passed
@xenolinux xenolinux deleted the multiarch-flag-hcp branch January 12, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants