Skip to content

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Jan 20, 2025

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

QE review:

  • QE has approved this change.

$${\color{red}Additional \space information:}$$
The changes in the PR are not yet user-facing

This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

I also included some small fixes for the other already transfered sections.


$${\color{red}Links \space to \space docs \space preview \space (with \space an \space explanation \space of \space what \space was \space changed:}$$

------------------------The assemblies above are the main changes---------------------

------------------------The following are minor inmprovements---------------------

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

…tion

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 20, 2025

🤖 Fri Jan 24 14:46:27 - Prow CI generated the docs preview:
https://87259--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@eromanova97 eromanova97 force-pushed the OBSDOCS-1628 branch 3 times, most recently from e020ebc to 9100512 Compare January 20, 2025 15:33
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

Links to docs preview (with an explanation of what was changed:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

Links to docs preview (with an explanation of what was changed:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

Links to docs preview (with an explanation of what was changed:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

Links to docs preview (with an explanation of what was changed:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

Links to docs preview (with an explanation of what was changed:

------------------------The assemblies above are the main changes---------------------

------------------------The following are minor inmprovements---------------------

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628



Links to docs preview (with an explanation of what was changed:

------------------------The assemblies above are the main changes---------------------

------------------------The following are minor inmprovements---------------------

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 changed the title [WIP] OBSDOCS-1628: Prepare the concept assembly in Monitoring Overview sec… OBSDOCS-1628: Prepare the concept assembly in Monitoring Overview sec… Jan 21, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

Additional information:
The changes in the PR are not yet user-facing

This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

I also included some small fixes for the other already transfered sections.


Links to docs preview (with an explanation of what was changed:

------------------------The assemblies above are the main changes---------------------

------------------------The following are minor inmprovements---------------------

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

$${\color{red}Additional \space information:}$$
The changes in the PR are not yet user-facing

This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

I also included some small fixes for the other already transfered sections.


Links to docs preview (with an explanation of what was changed:

------------------------The assemblies above are the main changes---------------------

------------------------The following are minor inmprovements---------------------

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

$${\color{red}Additional \space information:}$$
The changes in the PR are not yet user-facing

This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

I also included some small fixes for the other already transfered sections.


$${\color{red}Links \space to \space docs \space preview \space (with \space an \space explanation \space of \space what \space was \space changed:}$$

------------------------The assemblies above are the main changes---------------------

------------------------The following are minor inmprovements---------------------

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 force-pushed the OBSDOCS-1628 branch 3 times, most recently from 7e61f88 to d999535 Compare January 21, 2025 11:55
@juzhao
Copy link

juzhao commented Jan 21, 2025

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

$${\color{red}Additional \space information:}$$
The changes in the PR are not yet user-facing

This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

I also included some small fixes for the other already transfered sections.


$${\color{red}Links \space to \space docs \space preview \space (with \space an \space explanation \space of \space what \space was \space changed:}$$

------------------------The assemblies above are the main changes---------------------

------------------------The following are minor inmprovements---------------------

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025

@eromanova97: This pull request references OBSDOCS-1628 which is a valid jira issue.

In response to this:

Version(s): none for CP, monitoring-docs-restructure only

Issue: https://issues.redhat.com/browse/OBSDOCS-1628

QE review:

  • QE has approved this change.

$${\color{red}Additional \space information:}$$
The changes in the PR are not yet user-facing

This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

I also included some small fixes for the other already transfered sections.


$${\color{red}Links \space to \space docs \space preview \space (with \space an \space explanation \space of \space what \space was \space changed:}$$

------------------------The assemblies above are the main changes---------------------

------------------------The following are minor inmprovements---------------------

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 21, 2025
@adellape adellape self-assigned this Jan 21, 2025
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 21, 2025
@adellape adellape added this to the Continuous Release milestone Jan 21, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
Copy link

openshift-ci bot commented Jan 24, 2025

New changes are detected. LGTM label has been removed.

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 24, 2025
Copy link

openshift-ci bot commented Jan 24, 2025

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 24, 2025
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 24, 2025
@adellape adellape merged commit cc8df7d into openshift:monitoring-docs-restructure Jan 24, 2025
2 checks passed
@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 24, 2025
@eromanova97 eromanova97 deleted the OBSDOCS-1628 branch January 24, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants