Skip to content

OSDOCS-14322# Add hyperdisk limits for C3/N4 #93588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

OSDOCS-14322# Add hyperdisk limits for C3/N4 #93588

merged 1 commit into from
Aug 27, 2025

Conversation

@lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented May 20, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2025
@lpettyjo lpettyjo added branch/enterprise-4.18 branch/enterprise-4.19 peer-review-needed Signifies that the peer review team needs to review this PR labels May 20, 2025
@lpettyjo lpettyjo added this to the Continuous Release milestone May 20, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 20, 2025 •
edited
Loading

🤖 Wed Aug 27 13:48:28 - Prow CI generated the docs preview:

https://93588--ocpdocs-pr.netlify.app/microshift/latest/microshift_storage/understanding-persistent-storage-microshift.html
https://93588--ocpdocs-pr.netlify.app/openshift-dedicated/latest/storage/container_storage_interface/persistent-storage-csi-gcp-pd.html
https://93588--ocpdocs-pr.netlify.app/openshift-dedicated/latest/storage/understanding-persistent-storage.html
https://93588--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-gcp-pd.html
https://93588--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html
https://93588--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-persistent-storage.html
https://93588--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-persistent-storage.html

@aravipra
Copy link
Contributor

aravipra commented May 21, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 21, 2025
aravipra
aravipra reviewed May 21, 2025
View reviewed changes
aravipra
aravipra reviewed May 21, 2025
View reviewed changes
aravipra
aravipra reviewed May 21, 2025
View reviewed changes
aravipra
aravipra reviewed May 21, 2025
View reviewed changes
@aravipra
Copy link
Contributor

aravipra commented May 21, 2025

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 21, 2025
@aravipra
Copy link
Contributor

aravipra commented May 21, 2025

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label May 21, 2025
@aravipra
Copy link
Contributor

aravipra commented May 21, 2025

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label May 21, 2025
@aravipra
Copy link
Contributor

aravipra commented May 21, 2025

@lpettyjo please wait for my comments to be double checked as I am new to peer review.
@agantony please review the comments.

agantony
agantony reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted a few style guide issues; overall lgtm!

dfajmon
dfajmon reviewed May 26, 2025
View reviewed changes
gcharot
gcharot reviewed May 26, 2025
View reviewed changes
chao007
chao007 reviewed May 26, 2025
View reviewed changes
@lpettyjo lpettyjo force-pushed the OSDOCS-14322 branch 2 times, most recently from abc924d to d608e20 Compare May 29, 2025 16:05
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2025
@lpettyjo
Copy link
Contributor Author

lpettyjo commented May 30, 2025

/retest

@dfajmon
Copy link

dfajmon commented Jun 16, 2025

LGTM

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 16, 2025

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2025
@lpettyjo lpettyjo force-pushed the OSDOCS-14322 branch 3 times, most recently from 603a4a4 to 00ae318 Compare June 25, 2025 16:43
@chao007
Copy link

chao007 commented Jun 26, 2025

LGTM

gcharot
gcharot reviewed Aug 5, 2025
View reviewed changes
@gcharot
Copy link

gcharot commented Aug 26, 2025

lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lpettyjo lpettyjo merged commit d4aa679 into openshift:main Aug 27, 2025
2 checks passed
@lpettyjo
Copy link
Contributor Author

lpettyjo commented Aug 27, 2025

/cherrypick enterprise-4.20

@lpettyjo
Copy link
Contributor Author

lpettyjo commented Aug 27, 2025

/cherrypick enterprise-4.19

@lpettyjo
Copy link
Contributor Author

lpettyjo commented Aug 27, 2025

/cherrypick enterprise-4.18

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 27, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 27, 2025

@lpettyjo: new pull request created: #98104

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 27, 2025

@lpettyjo: new pull request created: #98105

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 27, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 27, 2025

@lpettyjo: new pull request created: #98106

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agantony agantony agantony left review comments

+4 more reviewers

@gcharot gcharot gcharot left review comments

@chao007 chao007 chao007 left review comments

@aravipra aravipra aravipra left review comments

@dfajmon dfajmon dfajmon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

10 participants

@lpettyjo @ocpdocs-previewbot @aravipra @dfajmon @bergerhoffer @chao007 @gcharot @openshift-cherrypick-robot @agantony @openshift-merge-robot