Skip to content

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Jun 2, 2025

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6468

Link to docs preview:

Enabling Argo Rollouts UI on an Argo CD instance

QE review:

  • QE has approved this change.

SME review: cfang@redhat.com
QE review: @varshab1210
Peer review:

Additional information:

A user, sshirodk@redhat.com, pointed out in this Slack thread that the module Enabling Argo Rollouts UI on an Argo CD instance was unavailable in the GitOps 1.16 branch. This PR is created to ensure that the missing module is added in the correct location.

CC: sshirodk@redhat.com

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6468

Link to docs preview:

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 2, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 2, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6468

Link to docs preview:

QE review:

  • QE has approved this change.

SME review: cfang@redhat.com
QE review:
Peer review:

Additional information:

A user, sshirodk@redhat.com, pointed out in this Slack thread that the module Enabling Argo Rollouts UI on an Argo CD instance was unavailable in the GitOps 1.16 branch. This PR is created to ensure that the missing module is added in the correct location.

CC: sshirodk@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6468

Link to docs preview:

Enabling Argo Rollouts UI on an Argo CD instance

QE review:

  • QE has approved this change.

SME review: cfang@redhat.com
QE review:
Peer review:

Additional information:

A user, sshirodk@redhat.com, pointed out in this Slack thread that the module Enabling Argo Rollouts UI on an Argo CD instance was unavailable in the GitOps 1.16 branch. This PR is created to ensure that the missing module is added in the correct location.

CC: sshirodk@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@chengfang chengfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 3, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6468

Link to docs preview:

Enabling Argo Rollouts UI on an Argo CD instance

QE review:

  • QE has approved this change.

SME review: cfang@redhat.com
QE review: @varshab1210
Peer review:

Additional information:

A user, sshirodk@redhat.com, pointed out in this Slack thread that the module Enabling Argo Rollouts UI on an Argo CD instance was unavailable in the GitOps 1.16 branch. This PR is created to ensure that the missing module is added in the correct location.

CC: sshirodk@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@varshab1210
Copy link

LGTM

@Dhruv-Soni11
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 3, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 3, 2025
@eromanova97
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

Copy link

openshift-ci bot commented Jun 3, 2025

@eromanova97: Those labels are not set on the issue: peer-review-needed

In response to this:

/remove-label peer-review-needed

/label peer-review-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I have finished the review.
I understand this is just a copy-paste type of PR, so my comments are just optional, out-of-scope suggestions for the existing module that can be implemented separately to include in all the versions.

Thank you!

/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 4, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6468

Link to docs preview:

Enabling Argo Rollouts UI on an Argo CD instance

QE review:

  • QE has approved this change.

SME review: cfang@redhat.com
QE review: @varshab1210
Peer review:

Additional information:

A user, sshirodk@redhat.com, pointed out in this Slack thread that the module Enabling Argo Rollouts UI on an Argo CD instance was unavailable in the GitOps 1.16 branch. This PR is created to ensure that the missing module is added in the correct location.

CC: sshirodk@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jun 4, 2025

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 4, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 4, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits but won't hold the merge.

[id="gitops-enabling-argo-rollouts-ui-on-an-argo-cd-instance_{context}"]
= Enabling Argo Rollouts UI on an Argo CD instance

To enable Argo Rollouts UI on an Argo CD instance, complete the following steps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To enable Argo Rollouts UI on an Argo CD instance, complete the following steps.
You can enable Argo Rollouts UI on an Argo CD instance.

Avoid self-referential language, such as "This topic covers…​" or "Use this procedure to…​".


. Click *YAML* and add the following configuration to configure the Argo Rollouts UI:
+
.Example enabling Argo Rollouts UI in the Argo CD CR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.Example enabling Argo Rollouts UI in the Argo CD CR
.Example enabling Argo Rollouts UI in the `ArgoCD` CR
  • Consider using the name of the CR - ArgoCD instead of plain text Argo CD

Comment on lines +40 to +41
enableRolloutsUI: true # <1>
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enableRolloutsUI: true # <1>
----
enableRolloutsUI: true # <1>
# ...
----

use an ellipsis (…​) to show that the file continues before or after the quoted block. For YAML, use ('#…​') instead.

server:
enableRolloutsUI: true # <1>
----
<1> Set this value to `true` to configure the `enableRolloutsUI` field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> Set this value to `true` to configure the `enableRolloutsUI` field.
<1> Set the value of the `enableRolloutsUI` field to `true`.

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 4, 2025
@xenolinux xenolinux merged commit dfae8bf into openshift:gitops-docs-1.16 Jun 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants