-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-6468: Adding a missing module in GitOps 1.16 #94081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-6468: Adding a missing module in GitOps 1.16 #94081
Conversation
@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Wed Jun 04 07:36:47 - Prow CI generated the docs preview: |
@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
LGTM |
/label peer-review-needed |
/remove-label peer-review-needed /label peer-review-in-progress |
@eromanova97: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I have finished the review.
I understand this is just a copy-paste type of PR, so my comments are just optional, out-of-scope suggestions for the existing module that can be implemented separately to include in all the versions.
Thank you!
/remove-label peer-review-in-progress
/label peer-review-done
modules/gitops-enabling-argo-rollouts-ui-on-an-argo-cd-instance.adoc
Outdated
Show resolved
Hide resolved
modules/gitops-enabling-argo-rollouts-ui-on-an-argo-cd-instance.adoc
Outdated
Show resolved
Hide resolved
modules/gitops-enabling-argo-rollouts-ui-on-an-argo-cd-instance.adoc
Outdated
Show resolved
Hide resolved
modules/gitops-enabling-argo-rollouts-ui-on-an-argo-cd-instance.adoc
Outdated
Show resolved
Hide resolved
@Dhruv-Soni11: This pull request references RHDEVDOCS-6468 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
77f1518
to
2cb4c33
Compare
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nits but won't hold the merge.
[id="gitops-enabling-argo-rollouts-ui-on-an-argo-cd-instance_{context}"] | ||
= Enabling Argo Rollouts UI on an Argo CD instance | ||
|
||
To enable Argo Rollouts UI on an Argo CD instance, complete the following steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To enable Argo Rollouts UI on an Argo CD instance, complete the following steps. | |
You can enable Argo Rollouts UI on an Argo CD instance. |
Avoid self-referential language, such as "This topic covers…" or "Use this procedure to…".
|
||
. Click *YAML* and add the following configuration to configure the Argo Rollouts UI: | ||
+ | ||
.Example enabling Argo Rollouts UI in the Argo CD CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Example enabling Argo Rollouts UI in the Argo CD CR | |
.Example enabling Argo Rollouts UI in the `ArgoCD` CR |
- Consider using the name of the CR -
ArgoCD
instead of plain text Argo CD
enableRolloutsUI: true # <1> | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enableRolloutsUI: true # <1> | |
---- | |
enableRolloutsUI: true # <1> | |
# ... | |
---- |
- If this YAML config is incomplete, see https://github.com/openshift/openshift-docs/blob/f9bab0fcb6e6353397e32183179ba9a3149af6a4/contributing_to_docs/doc_guidelines.adoc#signs-and-symbols-in-code-blocks
use an ellipsis (…) to show that the file continues before or after the quoted block. For YAML, use ('#…') instead.
server: | ||
enableRolloutsUI: true # <1> | ||
---- | ||
<1> Set this value to `true` to configure the `enableRolloutsUI` field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<1> Set this value to `true` to configure the `enableRolloutsUI` field. | |
<1> Set the value of the `enableRolloutsUI` field to `true`. |
Version(s):
GitOps 1.16
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6468
Link to docs preview:
Enabling Argo Rollouts UI on an Argo CD instance
QE review:
SME review: cfang@redhat.com
QE review: @varshab1210
Peer review:
Additional information:
A user, sshirodk@redhat.com, pointed out in this Slack thread that the module Enabling Argo Rollouts UI on an Argo CD instance was unavailable in the GitOps 1.16 branch. This PR is created to ensure that the missing module is added in the correct location.
CC: sshirodk@redhat.com