-
Notifications
You must be signed in to change notification settings - Fork 1.8k
PT2: Port the Log collection and forwarding chapter to 6.x #94410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PT2: Port the Log collection and forwarding chapter to 6.x #94410
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
🤖 Wed Sep 17 11:12:25 - Prow CI generated the docs preview: https://94410--ocpdocs-pr.netlify.app/ |
modules/cluster-logging-collector-log-forward-logs-from-application-pods.adoc
Outdated
Show resolved
Hide resolved
9ea74ae to
42f7c5b
Compare
modules/cluster-logging-collector-log-forward-logs-from-application-pods.adoc
Outdated
Show resolved
Hide resolved
modules/cluster-logging-collector-log-forward-logs-from-application-pods.adoc
Outdated
Show resolved
Hide resolved
42f7c5b to
850fefa
Compare
d46c304 to
da4df46
Compare
modules/cluster-logging-collector-log-forward-logs-from-application-pods.adoc
Outdated
Show resolved
Hide resolved
|
LGTM. |
|
Thanks, @QiaolingTang! |
gabriel-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - only very minor suggestions
7be1ae9 to
2a8af90
Compare
|
Thanks, @gabriel-rh for the review! |
briandooley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix typo. Also, the "Versions" in the initial description is blank. These must be resolved before merging.
2a8af90 to
799a31c
Compare
|
/retest |
|
Thanks, @briandooley for the review, I've made the required changes. best, ashwin |
briandooley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo.
799a31c to
bd6fe50
Compare
bd6fe50 to
ee280a4
Compare
|
@theashiot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5a2bc54
into
openshift:standalone-logging-docs-main
|
/cherrypick standalone-logging-docs-6.0 |
|
/cherrypick standalone-logging-docs-6.1 |
|
/cherrypick standalone-logging-docs-6.2 |
|
/cherrypick standalone-logging-docs-6.3 |
|
/cherrypick standalone-logging-docs-6.4 |
|
@briandooley: #94410 failed to apply on top of branch "standalone-logging-docs-6.0": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: #94410 failed to apply on top of branch "standalone-logging-docs-6.1": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: new pull request created: #99194 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: new pull request created: #99195 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: new pull request created: #99196 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 6.0+
Issue: https://issues.redhat.com/browse/OBSDOCS-2306
Link to docs preview: https://94410--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-log-forwarding.html
QE review:
Additional information: