Skip to content

Conversation

@gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Jul 2, 2025

https://issues.redhat.com/browse/POWERMON-579 Visualizing power monitoring metrics doc updates

Version(s):
Merge to only the power-monitoring-0.5 branch - no cherrypicks are required.
I will open one PR against main to incorporate all of the Power Monitoring content just before its GA.

Note to self: applies to 4.17+

Issue:
https://issues.redhat.com/browse/POWERMON-579

Link to docs preview:
https://95534--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/power_monitoring/visualizing-power-monitoring-metrics.html

QE review:

  • QE has approved this change.

Additional information:
Removal of [discrete] is being handled by #96676

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 2, 2025

@gwynnemonahan
Copy link
Contributor Author

power-monitoring-0.5 branch rebased against main 07/22/2025 by Brian D.

This PR rebased against power-monitoring-0.5 07/23/2025.

@vimalk78
Copy link

🤖 Tue Jul 29 21:59:36 - Prow CI generated the docs preview:

https://95534--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/power_monitoring/visualizing-power-monitoring-metrics.html

from the above link, we see a table for metrics which shows old metrics, we need to delete that section.

the metrics perhaps are coming from this module? modules/power-monitoring-metrics-overview.adoc

Copy link

@vimalk78 vimalk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove metric names appearing in "Visualizing power monitoring metrics" chapter

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@vimalk78 vimalk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2025
Copy link

@vprashar2929 vprashar2929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@gabriel-rh gabriel-rh merged commit 93da6b7 into openshift:power-monitoring-0.5 Jul 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants