Skip to content

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Jul 11, 2025

https://issues.redhat.com/browse/OCPBUGS-55692

MERGE REVIEWER: Can you PTAL while I try to determine which versions to cherrypick to?

Previews:
Overview of nodes -> About nodes -> Container runtime -- Updated text.
Cluster Network Operator configuration object -> Cluster Network Operator configuration object table -- Removed the spec.kubeProxyConfig row (formerly, the final row).

QE review:

  • Aditi Sahay has approved this change for Node.
  • Zhanqi Zhao has approved this change for Node.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 11, 2025

🤖 Thu Oct 30 21:07:49 - Prow CI generated the docs preview:
https://96002--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2025
@mburke5678
Copy link
Contributor Author

@asahay19 Can you assign a QE resource for this PR? Thank you very much.

@mburke5678 mburke5678 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2025
@asahay19
Copy link

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@mburke5678 mburke5678 force-pushed the node-description-not-match branch from d49435f to ffcb9cf Compare October 29, 2025 12:43
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@mburke5678 mburke5678 force-pushed the node-description-not-match branch from ffcb9cf to 244bd00 Compare October 29, 2025 12:44
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2025
@mburke5678
Copy link
Contributor Author

@zhaozhanqi Hello. I have a Nodes PR that is making a request to change a Networking doc:

Also From CNO configuration object table:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/networking_operators/cluster-network-operator#nw-operator-cr-cno-object_cluster-network-operator 

spec.kubeProxyConfig: The fields for this object specify the kube-proxy configuration. If you are using the OVN-Kubernetes cluster network plugin, the kube-proxy configuration has no effect.

we should remove this description since it is not necessary to expose this config anymore.

@ahardin-rh suggested you could review this commit for me:
c177fa7

Thank you in advance, and nice to work with you again.

@zhaozhanqi
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@mburke5678 mburke5678 force-pushed the node-description-not-match branch from c177fa7 to 40168a0 Compare October 30, 2025 19:49
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@mburke5678 mburke5678 added this to the Continuous Release milestone Oct 30, 2025
@mburke5678 mburke5678 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@mburke5678 mburke5678 force-pushed the node-description-not-match branch from 40168a0 to 6302e43 Compare October 30, 2025 20:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 30, 2025
@ShaunaDiaz ShaunaDiaz changed the title OCPBUGS55692: Node description does not match OpenShift configuration OCPBUGS#55692: Node description does not match OpenShift configuration Nov 6, 2025
@mburke5678
Copy link
Contributor Author

Per Peter Hunt in Slack, CP the runtime change to 4.12.
Per Ryan Phillips in Slack, CP the kube-proxy change to 4.18.

@mburke5678 mburke5678 merged commit 9ca3860 into openshift:main Nov 10, 2025
2 checks passed
@mburke5678 mburke5678 deleted the node-description-not-match branch November 10, 2025 21:56
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.18

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.19

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.20

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.21

@openshift-cherrypick-robot

@mburke5678: new pull request created: #102166

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #102167

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #102168

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants