-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TELCODOCS-2171#Remove refs to telco in Day2Ops Security files and file names #96103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
024562c to
610d513
Compare
|
Comment to peer reviewer: No files have been deleted. They've been renamed to remove |
|
LGTM |
5f3d546 to
e765e29
Compare
rohennes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, few small nits
edge_computing/day_2_core_cnf_clusters/security/security-basics.adoc
Outdated
Show resolved
Hide resolved
modules/security-infra.adoc
Outdated
|
|
||
| :_mod-docs-content-type: CONCEPT | ||
| [id="security-infra_{context}"] | ||
| = Bare metal-based infrastructure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| = Bare metal-based infrastructure | |
| = Bare-metal infrastructure |
modules/security-rbac-overview.adoc
Outdated
| * Cluster roles can be defined at the cluster level. They are not tied to a single namespace. They can apply across all namespaces or specific namespaces when you bind them to users, groups, or service accounts. | ||
| * Project roles can be created within a specific namespace, and they only apply to that namespace. You can assign permissions to specific users to create roles and role bindings within their namespace, ensuring they do not affect other namespaces. | ||
| Bindings:: Associations between users and/or groups with a role. You can create a role binding to connect the rules in a role to a specific user ID or group. This brings together the role and the user or group, defining what actions they can perform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and/or guidance from IBM style guide:
Do not use. Depending on the context, use one of the following constructions: a and b, a or b, or a, b, or both.
The construction and/or can be ambiguous and causes translation problems.
modules/security-rbac-overview.adoc
Outdated
| [id="security-operational-rbac-considerations_{context}"] | ||
| == Operational RBAC considerations | ||
|
|
||
| To reduce operational overhead, it is important to manage access through groups rather than handling individual user IDs across multiple clusters. By managing groups at an organizational level, you can streamline access control and simplify administration across your organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To reduce operational overhead, it is important to manage access through groups rather than handling individual user IDs across multiple clusters. By managing groups at an organizational level, you can streamline access control and simplify administration across your organization. | |
| To reduce operational overhead, manage access through groups rather than handling individual user IDs across multiple clusters. By managing groups at an organizational level, you can streamline access control and simplify administration across your organization. |
| [id="security-sec-considerations-{context}"] | ||
| = Security considerations | ||
|
|
||
| Corporate workloads handle sensitive data and demand high reliability. A single security vulnerability can lead to broader, cluster-wide compromises. With numerous components running on an OpenShift cluster, each component must be secured to prevent any breach from escalating. Ensuring security across the entire infrastructure, including all components, is essential to maintaining the integrity of the network and avoiding vulnerabilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Corporate workloads handle sensitive data and demand high reliability. A single security vulnerability can lead to broader, cluster-wide compromises. With numerous components running on an OpenShift cluster, each component must be secured to prevent any breach from escalating. Ensuring security across the entire infrastructure, including all components, is essential to maintaining the integrity of the network and avoiding vulnerabilities. | |
| Workloads might handle sensitive data and demand high reliability. A single security vulnerability might lead to broader, cluster-wide compromises. With numerous components running on an {product-title} cluster, you must secure each component to prevent any breach from escalating. Ensuring security across the entire infrastructure, including all components, is essential to maintaining the integrity of the network and avoiding vulnerabilities. |
| [id="security-sec-considerations-{context}"] | ||
| = Security considerations | ||
|
|
||
| Corporate workloads handle sensitive data and demand high reliability. A single security vulnerability can lead to broader, cluster-wide compromises. With numerous components running on an OpenShift cluster, each component must be secured to prevent any breach from escalating. Ensuring security across the entire infrastructure, including all components, is essential to maintaining the integrity of the network and avoiding vulnerabilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace OpenShift with {product-title} globally
361de76 to
7c92448
Compare
7c92448 to
bb77e90
Compare
|
@amolnar-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
@rohennes Hey! Could you please help me see if these PRs are needed? Can I close them or do you want me to keep this (and the rest of the Day2Ops) PRs open? |
Hey, who is this external contributor I see before me!!?? :-P Yeah you can close it if you like, Lluis CP'd it to his own PR. Hope all going well |
|
@rohennes Thank you, Ronan! Everything is going really great, I can't complain. Please say hi to team for me <3 <3 |
Version(s):
Issue: https://issues.redhat.com/browse/TELCODOCS-2171
Link to docs preview: https://96103--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/day_2_core_cnf_clusters/security/security-basics
QE review:
Additional information: