Skip to content

Conversation

@cchen666
Copy link

@cchen666 cchen666 commented Jul 25, 2025

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2025

Hi @cchen666. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2025
@cchen666
Copy link
Author

/label peer-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2025

@cchen666: The label(s) /label peer-review-needed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cchen666
Copy link
Author

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 28, 2025

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2025
@cchen666
Copy link
Author

/retest

1 similar comment
@cchen666
Copy link
Author

/retest

@cchen666
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 28, 2025
@lahinson lahinson added branch/enterprise-4.19 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 28, 2025
@lahinson lahinson added this to the Continuous Release milestone Jul 28, 2025
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cchen666 - Before this PR can be merged, please take the following steps:

  • Squash your commits to 1
  • Confirm whether this update is for 4.19 only
  • Confirm that this change has been approved by QE

Thank you!

@cchen666 cchen666 force-pushed the cchen-nmstate-dns branch from 857babe to 4e27cd8 Compare July 29, 2025 01:14
@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2025

@cchen666: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cchen666
Copy link
Author

Hi @rbbratta could you please help me to give QE approval for this. Thanks a lot!

@cchen666
Copy link
Author

Closing as this is a dup of #96788

@cchen666 cchen666 closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants