Skip to content

Conversation

@aksjadha
Copy link
Contributor

Update mco-update-boot-images-configuring.adoc to add correct label with "=" instead of ":"

Version(s):

Openshift 4.19

Issue:

Command mentioned to add label to machinset is not correct.

oc label machineset.machine ci-ln-hmy310k-72292-5f87z-worker-a region: "east" -n openshift-machine-api

This is giving error error: at least one label update is required

Correct command should be:

oc label machineset.machine ci-ln-hmy310k-72292-5f87z-worker-a region="east" -n openshift-machine-api

Link to docs preview:

https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html-single/machine_configuration/index#mco-update-boot-images-configuring_machine-configs-configure

QE review:

  • QE has approved this change.

Additional information:

…ith "=" instead of ":"

Update mco-update-boot-images-configuring.adoc to add correct label with "=" instead of ":"
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2025

Hi @aksjadha. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aksjadha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 31, 2025
@lahinson
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2025
@lahinson lahinson removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 31, 2025
@lahinson
Copy link
Contributor

Hi @aksjadha - Before you submit this PR for merge review, be sure to have it approved by QE. Thanks!

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2025

@aksjadha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor

Hi @aksjadha . The following PR has a dev engineer and QE that you could contact to approve your PR:#97038

@djoshy
Copy link

djoshy commented Aug 19, 2025

/lgtm from MCO team!

@mburke5678
Copy link
Contributor

@ptalgulk01 PTAL for QE

@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
@ptalgulk01
Copy link

lgtm too

@aksjadha
Copy link
Contributor Author

aksjadha commented Sep 3, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 3, 2025
@aksjadha
Copy link
Contributor Author

aksjadha commented Sep 3, 2025

@lahinson QE has reviewed PR. So now added merge-review-needed label. Let me know if missed anything

@dfitzmau dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.19 branch/enterprise-4.20 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 3, 2025
@dfitzmau dfitzmau merged commit 052f780 into openshift:main Sep 3, 2025
2 checks passed
@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

LGTM

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98454

In response to this:

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98455

In response to this:

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants