-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update mco-update-boot-images-configuring.adoc to add correct label with "=" instead of ":" #96719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ith "=" instead of ":" Update mco-update-boot-images-configuring.adoc to add correct label with "=" instead of ":"
|
Hi @aksjadha. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label merge-review-needed |
|
/ok-to-test |
|
Hi @aksjadha - Before you submit this PR for merge review, be sure to have it approved by QE. Thanks! |
|
🤖 Thu Jul 31 18:14:46 - Prow CI generated the docs preview: https://96719--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/mco-update-boot-images.html |
|
@aksjadha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm from MCO team! |
|
@ptalgulk01 PTAL for QE |
|
/lgtm |
|
lgtm too |
|
/label merge-review-needed |
|
@lahinson QE has reviewed PR. So now added merge-review-needed label. Let me know if missed anything |
|
LGTM |
|
/cherrypick enterprise-4.19 |
|
@dfitzmau: new pull request created: #98454 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #98455 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Update mco-update-boot-images-configuring.adoc to add correct label with "=" instead of ":"
Version(s):
Openshift 4.19
Issue:
Command mentioned to add label to machinset is not correct.
This is giving error
error: at least one label update is requiredCorrect command should be:
Link to docs preview:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html-single/machine_configuration/index#mco-update-boot-images-configuring_machine-configs-configure
QE review:
Additional information: