-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-15470-multiple-hardware-networks: Removed unneccessary code blocks for … #96759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-15470-multiple-hardware-networks: Removed unneccessary code blocks for … #96759
Conversation
77ca66e to
4993014
Compare
|
🤖 Mon Aug 18 11:51:49 - Prow CI generated the docs preview: |
5320b89 to
e1e2a82
Compare
|
Review multus files. |
…multi networks docs
e1e2a82 to
11f1c6c
Compare
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Reviewed sriov files. |
bscott-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge review LGTM.
|
/cherrypick enterprise-4.16 |
|
@bscott-rh: #96759 failed to apply on top of branch "enterprise-4.16": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.17 |
|
@bscott-rh: new pull request created: #98439 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bscott-rh: new pull request created: #98440 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bscott-rh: #96759 failed to apply on top of branch "enterprise-4.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bscott-rh: #96759 failed to apply on top of branch "enterprise-4.17": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR removes low-level code blocks from the Multiple networks and Hardware networks docs. Tried to remove passive from some files but this might distract from the core task.
Version(s):
4.16+
Issue:
OSDOCS-15470
Link to docs preview:
Epic = https://issues.redhat.com/browse/OSDOCS-15186