Skip to content

OBSDOCS-948: Follow up changes for http/syslog input docs #96822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

OBSDOCS-948: Follow up changes for http/syslog input docs #96822

merged 1 commit into from
Aug 28, 2025

Conversation

@theashiot
Copy link
Contributor

@theashiot theashiot commented Jul 29, 2025 •
edited
Loading

Version(s): 6.0+

Issue: https://issues.redhat.com/browse/OBSDOCS-948

Link to docs preview: https://96822--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/cluster-logging-collector.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 29, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-948 which is a valid jira issue.

In response to this:

Version(s): 6.0+

Issue: https://issues.redhat.com/browse/OBSDOCS-948

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@theashiot
Copy link
Contributor Author

theashiot commented Aug 5, 2025

/test all

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 5, 2025 •
edited
Loading

🤖 Thu Aug 28 12:34:06 - Prow CI generated the docs preview:

https://96822--ocpdocs-pr.netlify.app/
https://96822--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/cluster-logging-collector.html

@theashiot
Copy link
Contributor Author

theashiot commented Aug 6, 2025

/test all

@theashiot
Copy link
Contributor Author

theashiot commented Aug 6, 2025

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 6, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-948 which is a valid jira issue.

In response to this:

Version(s): 6.0+

Issue: https://issues.redhat.com/browse/OBSDOCS-948

Link to docs preview: https://96822--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/cluster-logging-collector.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theashiot theashiot marked this pull request as ready for review August 6, 2025 08:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2025
r2d2rnd
r2d2rnd reviewed Aug 11, 2025
View reviewed changes
@theashiot theashiot force-pushed the OBSDOCS-948 branch 2 times, most recently from 3f72c54 to ea4b375 Compare August 12, 2025 12:09
@anpingli
Copy link

anpingli commented Aug 13, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 13, 2025

New changes are detected. LGTM label has been removed.

@anpingli
Copy link

anpingli commented Aug 13, 2025

LGTM

@theashiot
Copy link
Contributor Author

theashiot commented Aug 14, 2025

Thanks, @anpingli!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 18, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-948 which is a valid jira issue.

In response to this:

Version(s): 6.0+

Issue: https://issues.redhat.com/browse/OBSDOCS-948

Link to docs preview: https://96822--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/cluster-logging-collector.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gabriel-rh
gabriel-rh approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one small typo

@theashiot
Copy link
Contributor Author

theashiot commented Aug 28, 2025

Thanks, @gabriel-rh for the review!

best,
ashwin

@briandooley briandooley added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 28, 2025
briandooley
briandooley requested changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@briandooley briandooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things to fix.

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2025

@theashiot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@briandooley briandooley merged commit 64e8d00 into openshift:standalone-logging-docs-main Aug 28, 2025
2 checks passed
@briandooley
Copy link
Contributor

briandooley commented Aug 28, 2025

/cherrypick standalone-logging-docs-6.3

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 28, 2025

@briandooley: new pull request created: #98155

In response to this:

/cherrypick standalone-logging-docs-6.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 28, 2025
Merged
@briandooley
Copy link
Contributor

briandooley commented Aug 28, 2025

/cherrypick standalone-logging-docs-6.2

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 28, 2025

@briandooley: new pull request created: #98156

In response to this:

/cherrypick standalone-logging-docs-6.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 28, 2025
Merged
@briandooley
Copy link
Contributor

briandooley commented Aug 28, 2025

/cherrypick standalone-logging-docs-6.1

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 28, 2025

@briandooley: new pull request created: #98157

In response to this:

/cherrypick standalone-logging-docs-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 28, 2025
Merged
@briandooley
Copy link
Contributor

briandooley commented Aug 28, 2025

/cherrypick standalone-logging-docs-6.0

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 28, 2025

@briandooley: new pull request created: #98158

In response to this:

/cherrypick standalone-logging-docs-6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandooley briandooley briandooley requested changes

@gabriel-rh gabriel-rh gabriel-rh approved these changes

+2 more reviewers

@anpingli anpingli anpingli left review comments

@r2d2rnd r2d2rnd r2d2rnd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@anpingli anpingli

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@theashiot @openshift-ci-robot @ocpdocs-previewbot @anpingli @briandooley @openshift-cherrypick-robot @r2d2rnd @gabriel-rh @openshift-merge-robot