OSDOCS#15587: CQA updates #96824

skopacz1 · 2025-07-29T20:02:06Z

🚨NOTE TO MERGE REVIEWER: I have merge rights, feel free to leave merging to me after your review, but it's okay if you merge it yourself.

OSDOCS-15587

Version(s): 4.17+

This PR makes style level edits to vSphere IPI install content as a result of doing a CQA.

QE review:

QE reviewed

Previews:

Installing a cluster (style/formatting changes throughout)
Installing a cluster with customizations (style/formatting changes throughout)
Configuring regions and zones for a VMware vCenter (technical info changed here)

openshift-ci-robot · 2025-07-29T20:02:10Z

@skopacz1: This pull request references OSDOCS-15587 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

OSDOCS-15587

Version(s): 4.16+

This PR makes style level edits to vSphere IPI install content as a result of doing a CQA.

QE review: QE not required

Previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2025-07-29T20:14:02Z

🤖 Tue Aug 05 16:35:46 - Prow CI generated the docs preview:
https://96824--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

bscott-rh · 2025-07-31T15:55:40Z

modules/configuring-vsphere-regions-zones.adoc

 ----

-. To create a region tag for each region vSphere data center where you want to deploy your cluster, enter the following command in your terminal:
+. For each region vSphere data center where you want to deploy your cluster, create a region tag by running the following command:


Suggested change

. For each region vSphere data center where you want to deploy your cluster, create a region tag by running the following command:

. For each region where you want to deploy your cluster, create a region tag by running the following command:

bscott-rh · 2025-07-31T15:58:47Z

modules/configuring-vsphere-regions-zones.adoc

 ----

-. To create a zone tag for each vSphere cluster where you want to deploy your cluster, enter the following command:
+. For each vSphere cluster where you want to deploy your cluster, create a zone tag by running the following command:


Suggested change

. For each vSphere cluster where you want to deploy your cluster, create a zone tag by running the following command:

. For each zone where you want to deploy your cluster, create a zone tag by running the following command:

jcpowermac · 2025-07-31T16:35:34Z

/lgtm

openshift-ci-robot · 2025-07-31T18:20:02Z

@skopacz1: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

OSDOCS-15587

Version(s): 4.16+

This PR makes style level edits to vSphere IPI install content as a result of doing a CQA.

QE review: QE not required

Previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

WenXinWei · 2025-08-05T03:41:31Z

/lgtm

dfitzmau · 2025-08-05T16:15:26Z

modules/registry-configuring-storage-vsphere.adoc

 <1> Leave the `claim` field blank to allow the automatic creation of an `image-registry-storage` persistent volume claim (PVC). The PVC is generated based on the default storage class. However, be aware that the default storage class might provide ReadWriteOnce (RWO) volumes, such as a RADOS Block Device (RBD), which can cause issues when you replicate to more than one replica.

-. Check the `clusteroperator` status:
+. Check the `clusteroperator` status by running the following command:


Might be out of scope, but I see a big spacial divide in the output between the VERSION column and the AVAILABLE column:

That is a big gap, let me try and delete that

dfitzmau · 2025-08-05T16:17:10Z

Hi, @skopacz1 . Getting near the end of my day so me waiting for CPs to pass might not suit you . Feel free to merge the PR. I added one minor comment inline.

dfitzmau · 2025-08-05T16:17:22Z

LGTM

openshift-ci · 2025-08-05T16:28:32Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2025-08-05T16:37:27Z

@skopacz1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

skopacz1 · 2025-08-05T20:34:02Z

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

openshift-cherrypick-robot · 2025-08-05T20:34:44Z

@skopacz1: #96824 failed to apply on top of branch "enterprise-4.16":

Applying: OSDOCS-15587: CQA updates
Using index info to reconstruct a base tree...
M	modules/cli-logging-in-kubeadmin.adoc
M	modules/cluster-entitlements.adoc
M	modules/configuring-vsphere-regions-zones.adoc
M	modules/installation-launching-installer.adoc
M	modules/ipi-install-modifying-install-config-for-dual-stack-network.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ipi-install-modifying-install-config-for-dual-stack-network.adoc
Auto-merging modules/installation-launching-installer.adoc
Auto-merging modules/configuring-vsphere-regions-zones.adoc
CONFLICT (content): Merge conflict in modules/configuring-vsphere-regions-zones.adoc
Auto-merging modules/cluster-entitlements.adoc
Auto-merging modules/cli-logging-in-kubeadmin.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-15587: CQA updates

In response to this:

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

skopacz1 · 2025-08-05T21:02:47Z

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

openshift-cherrypick-robot · 2025-08-05T21:03:43Z

@skopacz1: new pull request created: #97176

In response to this:

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-08-05T21:04:38Z

@skopacz1: new pull request created: #97177

In response to this:

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-08-05T21:05:32Z

@skopacz1: new pull request created: #97178

In response to this:

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-08-05T21:06:26Z

@skopacz1: new pull request created: #97179

In response to this:

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2025

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2025

bscott-rh reviewed Jul 31, 2025

View reviewed changes

openshift-ci bot assigned jcpowermac Jul 31, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025

skopacz1 force-pushed the CQA_fix_vsphere branch from c9105ce to 8b36151 Compare July 31, 2025 18:19

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025

skopacz1 changed the title ~~OSDOCS-15587: CQA updates~~ OSDOCS#15587: CQA updates Jul 31, 2025

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2025

skopacz1 added branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 labels Jul 31, 2025

skopacz1 modified the milestones: Planned for 4.20 GA, Continuous Release Jul 31, 2025

skopacz1 force-pushed the CQA_fix_vsphere branch from 8b36151 to a16631d Compare August 4, 2025 16:32

openshift-ci bot assigned WenXinWei Aug 5, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2025

skopacz1 added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 5, 2025

dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 5, 2025

dfitzmau reviewed Aug 5, 2025

View reviewed changes

dfitzmau removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 5, 2025

dfitzmau approved these changes Aug 5, 2025

View reviewed changes

OSDOCS-15587: CQA updates

4226a31

skopacz1 force-pushed the CQA_fix_vsphere branch from a16631d to 4226a31 Compare August 5, 2025 16:28

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2025

skopacz1 merged commit 30de33d into openshift:main Aug 5, 2025
2 checks passed

openshift-cherrypick-robot mentioned this pull request Aug 5, 2025

[enterprise-4.17] OSDOCS#15587: CQA updates #97176

Merged

openshift-cherrypick-robot mentioned this pull request Aug 5, 2025

[enterprise-4.18] OSDOCS#15587: CQA updates #97177

Merged

openshift-cherrypick-robot mentioned this pull request Aug 5, 2025

[enterprise-4.19] OSDOCS#15587: CQA updates #97178

Merged

openshift-cherrypick-robot mentioned this pull request Aug 5, 2025

[enterprise-4.20] OSDOCS#15587: CQA updates #97179

Merged

skopacz1 removed the branch/enterprise-4.16 label Aug 6, 2025

	. For each region vSphere data center where you want to deploy your cluster, create a region tag by running the following command:
	. For each region where you want to deploy your cluster, create a region tag by running the following command:

	. For each vSphere cluster where you want to deploy your cluster, create a zone tag by running the following command:
	. For each zone where you want to deploy your cluster, create a zone tag by running the following command:

OSDOCS#15587: CQA updates #96824

OSDOCS#15587: CQA updates #96824

Uh oh!

Conversation

skopacz1 commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 29, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bscott-rh Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

bscott-rh Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

jcpowermac commented Jul 31, 2025

Uh oh!

openshift-ci-robot commented Jul 31, 2025

Uh oh!

WenXinWei commented Aug 5, 2025

Uh oh!

dfitzmau Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

skopacz1 Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

dfitzmau commented Aug 5, 2025

Uh oh!

dfitzmau commented Aug 5, 2025

Uh oh!

openshift-ci bot commented Aug 5, 2025

Uh oh!

openshift-ci bot commented Aug 5, 2025

Uh oh!

Uh oh!

skopacz1 commented Aug 5, 2025

Uh oh!

openshift-cherrypick-robot commented Aug 5, 2025

Uh oh!

skopacz1 commented Aug 5, 2025

Uh oh!

openshift-cherrypick-robot commented Aug 5, 2025

Uh oh!

openshift-cherrypick-robot commented Aug 5, 2025

Uh oh!

openshift-cherrypick-robot commented Aug 5, 2025

Uh oh!

openshift-cherrypick-robot commented Aug 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

skopacz1 commented Jul 29, 2025 •

edited

Loading

openshift-ci-robot commented Jul 29, 2025 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Jul 29, 2025 •

edited

Loading