Skip to content

TELCODOCS-2259: Add TP support for ARM dual-port OC #96925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

TELCODOCS-2259: Add TP support for ARM dual-port OC #96925

merged 1 commit into from
Sep 3, 2025

Conversation

@rohennes
Copy link
Contributor

@rohennes rohennes commented Jul 31, 2025 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2259: Add TP support for ARM dual-port OC

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2259

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 31, 2025 •
edited
Loading

🤖 Wed Sep 03 14:08:05 - Prow CI generated the docs preview:

https://96925--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/advanced_networking/ptp/about-ptp.html
https://96925--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/advanced_networking/ptp/configuring-ptp.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2259: Add TP support for ARM dual-port OC

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2259

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

edcdavid
edcdavid reviewed Jul 31, 2025
View reviewed changes
modules/ptp-dual-ports-oc.adoc Outdated
[NOTE]
====
You can configure PTP ordinary clocks with added redundancy on `x86` architecture nodes with dual-port NICs only.
You must configure the NVIDIA BlueField-3 series DPU in NIC mode before configuring the interface as an ordinary clock with improved redundancy. For further information about configuring NIC mode, see link:https://docs.nvidia.com/networking/display/bluefielddpubspv422/modes+of+operation#src-141856548_ModesofOperation-NICModeforBlueField-3[NIC Mode for BlueField-3] (NVIDIA documentation).
Copy link

@edcdavid edcdavid Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note about the new required Nvidia driver for this feature? This allows mellanox cards to expose 1 phc per NIC instead of multiple (virtual) ones. Intel cards are already exposing only one phc per nic. See https://issues.redhat.com/browse/RHEL-87775

Copy link
Contributor Author

@rohennes rohennes Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David, I included a line that says you must use the latest Nvidia drivers/firmware. Perhaps this covers it? I couldn't determine the exact versions it was introduced.

@rohennes rohennes force-pushed the TELCODOCS-2259 branch 2 times, most recently from f9025b8 to 213f8b2 Compare August 18, 2025 10:39
edcdavid
edcdavid reviewed Aug 18, 2025
View reviewed changes
modules/ptp-dual-ports-oc.adoc Outdated
* NVIDIA BlueField-3 series, in NIC mode
** You must configure the NVIDIA BlueField-3 series DPU in NIC mode before configuring the interface as an ordinary clock with improved redundancy. For further information about configuring NIC mode, see link:https://docs.nvidia.com/networking/display/bluefielddpubspv422/modes+of+operation#src-141856548_ModesofOperation-NICModeforBlueField-3[NIC Mode for BlueField-3] (NVIDIA documentation).
Copy link

@edcdavid edcdavid Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To configure NIC mode on BF3 should we add also these 2 additional options:

using the card’s own BMC: https://docs.nvidia.com/networking/display/bluefieldbmcv2504/bluefield+management

The host server bios sometimes also supports configuring the NIC mode: https://docs.nvidia.com/networking/display/bluefielddpuosv470/modes+of+operation#src-2821766680_ModesofOperation-ConfiguringNICModeonBlueField-3fromHostHIIUEFI

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2259: Add TP support for ARM dual-port OC

NOTE: This may not make GA due to engineering issues, but drafting this up in any case so it is ready if it does make GA.

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2259

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

NOTE: This may not make GA due to engineering issues, but drafting this up in any case so it is ready if it does make GA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dpopsuev
Copy link

dpopsuev commented Aug 19, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2025

@dpopsuev: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2259: Add TP support for ARM dual-port OC

NOTE: This may not make GA due to engineering issues, but drafting this up in any case so it is ready if it does make GA.

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2259

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

NOTE: This may not make GA due to engineering issues, but drafting this up in any case so it is ready if it does make GA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2259: Add TP support for ARM dual-port OC

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2259

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lcavalle
Copy link
Contributor

lcavalle commented Aug 25, 2025 •
edited
Loading

/lgtm

amolnar-gh
amolnar-gh reviewed Sep 2, 2025
View reviewed changes
modules/ptp-dual-ports-oc.adoc Outdated
====
You can configure PTP ordinary clocks with added redundancy on `x86` architecture nodes with dual-port NICs only.
====
.Hardware requirements
Copy link
Contributor

@amolnar-gh amolnar-gh Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"DITA does not support block titles that are not in the templates or are not part of a table, example, or figure." (source)

Consider changing this to H2 (==).

Copy link
Contributor Author

@rohennes rohennes Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolnar-rh - pushed the fix

@amolnar-gh amolnar-gh added this to the Planned for 4.20 GA milestone Sep 2, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 3, 2025

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amolnar-gh amolnar-gh merged commit d79d867 into openshift:main Sep 3, 2025
2 checks passed
@amolnar-gh
Copy link
Contributor

amolnar-gh commented Sep 3, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 3, 2025

@amolnar-rh: new pull request created: #98451

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@amolnar-gh amolnar-gh amolnar-gh left review comments

@edcdavid edcdavid edcdavid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.20 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@rohennes @openshift-ci-robot @ocpdocs-previewbot @dpopsuev @lcavalle @amolnar-gh @openshift-cherrypick-robot @edcdavid