-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-13626: updates oc mirror to v2 MicroShift #97064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ShaunaDiaz: This pull request references OSDOCS-13626 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
91431bf
to
693a888
Compare
@ShaunaDiaz: This pull request references OSDOCS-13626 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
693a888
to
77892c4
Compare
77892c4
to
3576c95
Compare
microshift_running_apps/microshift_operators/microshift-operators-oc-mirror.adoc
Outdated
Show resolved
Hide resolved
microshift_running_apps/microshift_operators/microshift-operators-oc-mirror.adoc
Outdated
Show resolved
Hide resolved
b6ad2a5
to
7fe575d
Compare
b0fe221
to
6a81846
Compare
@ShaunaDiaz: This pull request references OSDOCS-13626 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ShaunaDiaz: This pull request references OSDOCS-13626 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShaunaDiaz I made a few suggestions for you to consider, either for this PR or a separate one. I'll leave this in your hands to merge :)
microshift_running_apps/microshift_operators/microshift-operators-oc-mirror.adoc
Show resolved
Hide resolved
microshift_running_apps/microshift_operators/microshift-operators-oc-mirror.adoc
Outdated
Show resolved
Hide resolved
microshift_running_apps/microshift_operators/microshift-operators-olm.adoc
Outdated
Show resolved
Hide resolved
6a81846
to
9d4b9c5
Compare
@ShaunaDiaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick enterprise-4.20 |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.18 |
@ShaunaDiaz: #97064 failed to apply on top of branch "enterprise-4.19":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #99388 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: #97064 failed to apply on top of branch "enterprise-4.18":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.18+
Issue:
OSDOCS-13626
Link to docs preview:
https://97064--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift_operators/microshift-operators-oc-mirror.html
https://97064--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift_operators/microshift-operators-oc-mirror-disconnected#oc-mirror-dry-run_microshift-operators-oc-mirror-disconnected
QE review:
Additional info: QE is still testing, so please review and place an
ok-to-merge
label if all is well. I'll merge it when QE is done testing in case there are small changes.