OSDOCS-13847:Generic Device Plugin Feature #97090
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tedaveryredhat: This pull request references OSDOCS-13847 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XL
|
🤖 Wed Sep 10 18:56:13 - Prow CI generated the docs preview: https://97090--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-gdp.html |
modules/microshift-con-limitations-of-generic-device-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/microshift-con-limitations-of-generic-device-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/microshift-proc-deploying-workloads-with-generic-devices.adoc
Outdated
Show resolved
Hide resolved
modules/microshift-ref-generic-device-plugin-configuration-parameters.adoc
Outdated
Show resolved
Hide resolved
modules/ref-generic-device-plugin-configuration-parameters.adoc
Outdated
Show resolved
Hide resolved
tedaveryredhat
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
tedaveryredhat
force-pushed
the
OSDOCS-13847
branch
from
065ce05 to
a274a64
Compare
openshift-ci
bot
added
size/L
tedaveryredhat
force-pushed
the
OSDOCS-13847
branch
from
27cd20c to
e043e08
Compare
modules/microshift-proc-deploying-applications-with-generic-devices.adoc
Show resolved
Hide resolved
tedaveryredhat
force-pushed
the
OSDOCS-13847
branch
from
e043e08 to
535890f
Compare
modules/microshift-proc-deploying-applications-with-generic-devices.adoc
Outdated
Show resolved
Hide resolved
tedaveryredhat
force-pushed
the
OSDOCS-13847
branch
from
535890f to
7d1de71
Compare
|
/lgtm |
|
@tedaveryredhat: This pull request references OSDOCS-13847 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tedaveryredhat
force-pushed
the
OSDOCS-13847
branch
from
7d1de71 to
6a32351
Compare
|
/label merge-review-needed |
ShaunaDiaz
added
the
merge-review-in-progress
There was a problem hiding this comment.
This looks really good!
Two things are still not compliant: 1) .Verification and .Results sections, see https://raw.githubusercontent.com/redhat-documentation/modular-docs/master/modular-docs-manual/files/TEMPLATE_PROCEDURE_doing-one-procedure.adoc and the 2) Important admonition in the procedure.
There are also a few nits I mention that are not blockers, but the mod docs compliance must be fixed. You can make a touch-up issue and come back for the admonition and the other nits, but do fix the .Verification sections.
modules/microshift-proc-deploying-applications-with-generic-devices.adoc
Outdated
Show resolved
Hide resolved
modules/microshift-proc-deploying-applications-with-generic-devices.adoc
Outdated
Show resolved
Hide resolved
modules/microshift-proc-deploying-applications-with-generic-devices.adoc
Outdated
Show resolved
Hide resolved
modules/microshift-proc-deploying-applications-with-generic-devices.adoc
Outdated
Show resolved
Hide resolved
| [id="microshift-generic-device-plugin-troubleshooting_{context}"] | ||
| = Troubleshooting configuration issues | ||
|
|
||
| If you encounter errors such as "invalid configuration: failed to parse device" or "cannot define both path and usbs at the same time", it means you have incorrectly mixed `paths` and `usbs` fields within the same `groups` entry for a device. Each `group` must exclusively use either `paths` or `usbs` to define its devices. No newline at end of file |
There was a problem hiding this comment.
can we add a "wrong" and "fixed" example to this later on? perhaps a follow-up issue for GA in 4.21?
ShaunaDiaz
removed
the
merge-review-in-progress
tedaveryredhat
force-pushed
the
OSDOCS-13847
branch
from
6a32351 to
9ec7b33
Compare
tedaveryredhat
force-pushed
the
OSDOCS-13847
branch
from
9ec7b33 to
86cf18f
Compare
|
@tedaveryredhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
@ShaunaDiaz: new pull request created: #98843 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8 participants
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/OSDOCS-13847, https://issues.redhat.com/browse/OSDOCS-14898
Link to docs preview:
https://97090--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-gdp.html
QE review: