Skip to content

oadp s3 bucket version support #97094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

oadp s3 bucket version support #97094

merged 1 commit into from
Sep 22, 2025

Conversation

shdeshpa07
Copy link
Contributor

@shdeshpa07 shdeshpa07 commented Aug 5, 2025 •
edited
Loading

Jira

AWS S3 bucket versioning support

Version

  • OCP 4.14 → OCP 4.20

Preview

QE Review

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 5, 2025 •
edited
Loading

🤖 Tue Sep 16 11:55:31 - Prow CI generated the docs preview:

https://97094--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html

@shdeshpa07
Copy link
Contributor Author

/label OADP

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Aug 5, 2025
@shdeshpa07
Copy link
Contributor Author

@PrasadJoshi12 @weshayutin - Could you please review this PR? Thanks.

@PrasadJoshi12
Copy link
Contributor

@shdeshpa07 User might think its still not supported by the heading statement. Maybe we should update it as well

Starting with OADP 1.3, backups might not function as expected when the target object storage has an immutability option configured. These immutability options are referred to by different names, for example:

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Aug 18, 2025 •
edited
Loading

@shdeshpa07 User might think its still not supported by the heading statement. Maybe we should update it as well

Starting with OADP 1.3, backups might not function as expected when the target object storage has an immutability option configured. These immutability options are referred to by different names, for example:

Thanks @PrasadJoshi12 - As the support for versioning is only for AWS S3 and not other S3-compatible storage, I have made changes in the title and the following paragraph accordingly.

Can you please review again?

Also, I think this PR also resolves this doc ticket OADP-5642 about adding a mention that object locking is not supported in S3-compatible storage types.

@weshayutin - Could you please review and let me know if this PR also resolves OADP-5642?

Thanks.

weshayutin
weshayutin reviewed Aug 19, 2025
View reviewed changes
weshayutin
weshayutin reviewed Aug 19, 2025
View reviewed changes
weshayutin
weshayutin reviewed Aug 19, 2025
View reviewed changes
@PrasadJoshi12
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
@shdeshpa07
Copy link
Contributor Author

@vashirova - Could you please review this PR? Thanks.

vashirova
vashirova approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@vashirova vashirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shdeshpa07 peer review completed, I've added my suggestions. Let me know if anything is unclear. Overall brilliant work, thank you for the opportunity!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 16, 2025

New changes are detected. LGTM label has been removed.

@shdeshpa07
oadp s3 bucket version support
b455ee3 
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
@shdeshpa07 shdeshpa07 force-pushed the OADP-5974-aws-s3-versioning branch from 0d62308 to b455ee3 Compare September 16, 2025 11:46
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 16, 2025

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shdeshpa07 shdeshpa07 added this to the Continuous Release milestone Sep 22, 2025
@shdeshpa07 shdeshpa07 merged commit 2a874b0 into openshift:main Sep 22, 2025
2 checks passed
@shdeshpa07
Copy link
Contributor Author

/cherrypick enterprise-4.20

@shdeshpa07
Copy link
Contributor Author

/cherrypick enterprise-4.19

@shdeshpa07
Copy link
Contributor Author

/cherrypick enterprise-4.18

@shdeshpa07
Copy link
Contributor Author

/cherrypick enterprise-4.17

@shdeshpa07
Copy link
Contributor Author

/cherrypick enterprise-4.16

@shdeshpa07
Copy link
Contributor Author

/cherrypick enterprise-4.15

@shdeshpa07
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@shdeshpa07: new pull request created: #99442

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@shdeshpa07: new pull request created: #99443

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@shdeshpa07: new pull request created: #99444

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@shdeshpa07: new pull request created: #99445

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@shdeshpa07: new pull request created: #99446

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@shdeshpa07: new pull request created: #99447

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@shdeshpa07: new pull request created: #99448

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@weshayutin weshayutin weshayutin left review comments

@stillalearner stillalearner stillalearner left review comments

@PrasadJoshi12 PrasadJoshi12 PrasadJoshi12 approved these changes

@vashirova vashirova vashirova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PrasadJoshi12 PrasadJoshi12

Labels

branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 OADP Label for all OADP PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@shdeshpa07 @ocpdocs-previewbot @PrasadJoshi12 @openshift-cherrypick-robot @weshayutin @stillalearner @vashirova